Add support for jspecify annotations#4985
Open
weberhofer wants to merge 10 commits intoswagger-api:masterfrom
Open
Add support for jspecify annotations#4985weberhofer wants to merge 10 commits intoswagger-api:masterfrom
weberhofer wants to merge 10 commits intoswagger-api:masterfrom
Conversation
nealeu
reviewed
Nov 20, 2025
Comment on lines
1
to
4
| @NullUnmarked | ||
| package io.swagger.v3.jaxrs2.resources.jspecify.nullunmarked; | ||
|
|
||
| import org.jspecify.annotations.NullUnmarked; No newline at end of file |
There was a problem hiding this comment.
From my understanding of JSpecify, @NullUnmarked is only relevant within a @NullMarked package, so you could move this package to ...jspecify.nullmarked.nullunmarked
Author
There was a problem hiding this comment.
Thanks for reviewing. I have updated the PR.
There was a problem hiding this comment.
You're welcome.
Unfortunately that's all I can do as I'm not on the team.
Another suggestion is that you might be better to rebase your commits onto main and force push, instead of merging it in. Typically maintainers prefer PRs without merge commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR adds support for the JSpecify annotations: @NullMarked, @NullUnmarked, @nullable, @nonnull
Fixes: #4848
Type of Change
Checklist