[Bug Fix]: Handle null property types in OpenAPI 3.1.0 schemas - DefaultCodegen.java #12675
+187
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue swagger-api#12666 where string, boolean, and integer properties were being incorrectly converted to Object types when generating code from OpenAPI 3.1.0 specifications. Changes: - Modified getSwaggerType() to handle null property types gracefully - Added inferTypeFromFormat() helper to infer types from format strings - Added final fallback to return 'object' instead of null - Added comprehensive test cases for the fix
Author
|
Hi, @djankows This is ready for review, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #12666
Description
This PR fixes an issue where string, boolean, and integer properties were being incorrectly converted to
Objecttypes when generating code from OpenAPI 3.1.0 specifications. The root cause was that the swagger-parser may return properties with null types when parsing OpenAPI 3.1.0 schemas (which use JSON Schema 2020-12), causing thegetSwaggerType()method to return null, which then propagated through to the generated code asObject.Changes:
getSwaggerType()inDefaultCodegen.javato handle null property types gracefullyinferTypeFromFormat()helper method to infer types from format strings when type is null (e.g.,int32→integer,date-time→DateTime)Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=100145226