perf: poc of validation service improvements#5166
Open
glowcloud wants to merge 6 commits into
Open
Conversation
Comment on lines
+270
to
+271
| (member as any).content.key = keyElement; | ||
| (member as any).content.value = valueElement; |
Contributor
There was a problem hiding this comment.
perhaps we could use some type guard here 🤔
Contributor
Author
There was a problem hiding this comment.
Turns out we can assign directly to key/value. Also, I forgot to commit changes to adapter node/browser so direct analysis was not running 🤦 Fixed this as well.
robert-hebel-sb
approved these changes
May 11, 2026
cka121
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC of validation improvements: