update sw360python & refactor SBomWriter #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sw360python 1.2.2 includes a fix to detect failed downloads. This might fix sporadic, inconsistent downloads in "project getlicenseinfo".
It's not necessary to write and read SBOM to pretty print, we can also just post-process the string representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two small improvements I developed in the context of #33 which might be worth to be merged already now.
First, we should update sw360python to 1.2.2 to include the fix for download_release_attachment() which could silently ignore download failures and thus probably lead to inconsistent CLI files in "project getlicenseinfo".
Second, I refactored the SBomWriter to avoid creation of a temporary file when writing a BOM with
pretty_print.