Skip to content

Conversation

@yanick
Copy link
Contributor

@yanick yanick commented Jan 13, 2015

Add support for Sereal

@dams
Copy link
Contributor

dams commented Jan 13, 2015

you might want to look at Log::Message::Structured::Stringify::Sereal, for easy message creation. Nothing related to this PR code-wise, just connecting the dots between module...

@yanick
Copy link
Contributor Author

yanick commented Jan 14, 2015

Oh, hi dams! :-)

Reference noted. In this case it pretty much amount to the same thing, but indeed, it's nice to connect the dots and make sure there is no duplication.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need MooX::Types::MooseLike::Base here ? Seems like you never use these types ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On 2015-11-03 03:03 PM, Damien Krotkine wrote:

In lib/Message/Passing/Filter/Encoder/Sereal.pm
#10 (comment):

@@ -0,0 +1,92 @@
+package Message::Passing::Filter::Encoder::Sereal;
+use Moo;
+use MooX::Types::MooseLike::Base qw( Bool HasMethods );

Why do you need MooX::Types::MooseLike::Base here ? Seems like you never
use these types ?

Good point. I think it was a direct port (and lack of after-the-fact
cleanup) of the JSON serializer. Pushed a commit that removes that line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants