feat: adopt PostgreSQL's naming convention of temporary files and directories#116
Merged
Merged
Conversation
…ectories Signed-off-by: usamoi <usamoi@outlook.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adopts PostgreSQL-like naming/location for temporary files/directories used during BM25 index maintenance/build operations.
Changes:
- Added a Postgres-style temp name generator and new temp file/dir utilities under
src/index/temp.rs. - Updated BM25 maintenance/vacuum and build paths to use the new temp dir/file plumbing.
- Adjusted workspace dependency usage (notably
getrandom/rand) and removedtempfilefrom core workspace deps.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Adds tempname() generator used for PG-style temp paths. |
| src/index/temp.rs | New temp file/dir helpers that create artifacts under temp tablespaces. |
| src/index/mod.rs | Registers the new temp module. |
| src/index/bm25/am/am_vacuumcleanup.rs | Passes temp dir/file paths into BM25 maintenance. |
| src/index/bm25/am/am_build.rs | Switches build temp directory creation to the new temp helper; reseeds RNG in parallel worker entry. |
| crates/bm25/src/maintain.rs | Changes maintain() signature to accept temp dir/file paths and uses them for IO. |
| crates/xtask/Cargo.toml | Pins tempfile directly instead of workspace dependency. |
| crates/bm25/Cargo.toml | Switches getrandom to workspace; removes tempfile workspace dep usage. |
| Cargo.toml | Adds getrandom/rand workspace usage and removes tempfile from workspace deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.