Skip to content

feat: adopt PostgreSQL's naming convention of temporary files and directories#116

Merged
usamoi merged 1 commit into
supervc-stack:mainfrom
usamoi:postgres-temp
Apr 27, 2026
Merged

feat: adopt PostgreSQL's naming convention of temporary files and directories#116
usamoi merged 1 commit into
supervc-stack:mainfrom
usamoi:postgres-temp

Conversation

@usamoi
Copy link
Copy Markdown
Contributor

@usamoi usamoi commented Apr 27, 2026

No description provided.

…ectories

Signed-off-by: usamoi <usamoi@outlook.com>
@usamoi usamoi merged commit cc9fe2d into supervc-stack:main Apr 27, 2026
20 checks passed
@usamoi usamoi requested a review from Copilot April 27, 2026 08:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adopts PostgreSQL-like naming/location for temporary files/directories used during BM25 index maintenance/build operations.

Changes:

  • Added a Postgres-style temp name generator and new temp file/dir utilities under src/index/temp.rs.
  • Updated BM25 maintenance/vacuum and build paths to use the new temp dir/file plumbing.
  • Adjusted workspace dependency usage (notably getrandom/rand) and removed tempfile from core workspace deps.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/lib.rs Adds tempname() generator used for PG-style temp paths.
src/index/temp.rs New temp file/dir helpers that create artifacts under temp tablespaces.
src/index/mod.rs Registers the new temp module.
src/index/bm25/am/am_vacuumcleanup.rs Passes temp dir/file paths into BM25 maintenance.
src/index/bm25/am/am_build.rs Switches build temp directory creation to the new temp helper; reseeds RNG in parallel worker entry.
crates/bm25/src/maintain.rs Changes maintain() signature to accept temp dir/file paths and uses them for IO.
crates/xtask/Cargo.toml Pins tempfile directly instead of workspace dependency.
crates/bm25/Cargo.toml Switches getrandom to workspace; removes tempfile workspace dep usage.
Cargo.toml Adds getrandom/rand workspace usage and removes tempfile from workspace deps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/lib.rs
Comment thread src/index/temp.rs
Comment thread crates/bm25/src/maintain.rs
Comment thread src/index/temp.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants