fix(tweet-preview): guard JSON.parse to avoid crashing the modal

[vimzh]

TweetPreview runs JSON.parse(data) on the data prop with no try/catch. If a document's stored Twitter metadata is ever malformed (truncated JSON, corrupted serialization, exotic stringified values like "null" or "123"), the parse throws and the React tree rendering the document modal or memory card crashes.

This wraps the parse in a small parseTweetData helper that returns null when:

• The input is empty or null
• JSON.parse throws
• The parsed value isn't a plain object (covers arrays, which would otherwise slip past a typeof === "object" check and crash deeper in enrichTweet)

When parsing returns null the component renders nothing instead of crashing. Also widened the prop type from Tweet to Tweet | string to match what both call sites already pass via as Tweet / as unknown as Tweet.

One thing worth flagging for reviewers: in apps/web/components/document-modal/content/tweet.tsx the TweetPreview branch is entered whenever tweetMetadata is truthy, so malformed metadata now renders an empty container rather than the "Tweet preview unavailable" fallback further down that file. That is strictly better than crashing but not the friendliest UX. Happy to move the validation up into TweetContent in a follow-up if you would prefer the explicit fallback.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR makes TweetPreview resilient to tweet data being passed as a JSON string by adding safe parsing and avoiding render-time exceptions on invalid input.

Changes:

• Added parseTweetData helper to safely parse tweet JSON strings with try/catch.
• Updated TweetPreview prop type to accept Tweet | string.
• Short-circuited rendering (return null) when parsing fails.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ishaanxgupta]

parseTweetData() only checks that the parsed value is a non-array object with a "user" key:

"user" in value

But enrichTweet(parsedTweet) still assumes the full Tweet shape exists. So valid JSON like these can still pass isTweetLike() and crash during render:

{"user": null}
{"user": {}}
{"user": {}, "text": null}

For example, enrichTweet reads fields like tweet.user.screen_name, tweet.text, tweet.display_text_range, and tweet.entities.*. If any of those are missing or malformed, we’re past the parse guard and the React tree can still throw.