perf: wrap list/grid components in React.memo to skip unnecessary re-renders#847
Open
ved015 wants to merge 3 commits intosupermemoryai:mainfrom
Open
perf: wrap list/grid components in React.memo to skip unnecessary re-renders#847ved015 wants to merge 3 commits intosupermemoryai:mainfrom
ved015 wants to merge 3 commits intosupermemoryai:mainfrom
Conversation
ved015
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserMessage,WebsitePreview,YoutubePreview, andFilePreviewinReact.memo()to prevent unnecessary re rendersWhy
These components render inside lists/grids that can have 50+ items. Any parent state change (eg new streaming token in chat, selection toggle in grid) causes all of them to re render even though their props have not changed.
Impact