perf(ui): precalculate document embeddings for graph similarity#844
Open
ishaanxgupta wants to merge 1 commit intosupermemoryai:mainfrom
Open
perf(ui): precalculate document embeddings for graph similarity#844ishaanxgupta wants to merge 1 commit intosupermemoryai:mainfrom
ishaanxgupta wants to merge 1 commit intosupermemoryai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Array.from(doc.summaryEmbedding)out of the nestedforloop inuseGraphData.In
packages/ui/memory-graph/hooks/use-graph-data.ts, we were callingArray.from(doc.summaryEmbedding)repeatedly within an O(n^2) inner loop. This triggered heavy garbage collection and continuous array allocation when iterating over document pairs for semantic similarity.I pulled the embedding extraction into an O(n) mapping pass before the nested loops:
Then we simply reference docEmbeddings[i] and docEmbeddings[j] within the$O(n^2)$ loop. This eliminates the heavy GC pressure and directly improves framing times during document selection and graph panning operations.