Fix process hangs: add timeouts and fix atexit handler conflict#17
Open
Fix process hangs: add timeouts and fix atexit handler conflict#17
Conversation
- Add timeout=30 to quickstart example command to prevent indefinite blocking on WebSocket hangs - Change checkpoint HTTP client timeout from None to 300s to prevent indefinite blocking on slow API responses - Fix atexit handler to skip cleanup if the event loop was already stopped by loop.py's handler, preventing creation of a new loop during shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
control.py's atexit handler could create a new event loop afterloop.py's handler already stopped it (LIFO ordering), causing a hang during shutdown. Now checks if_loopisNonebefore attempting cleanup.checkpoint.pyusedtimeout=Nonefor create/restore, meaning requests could block forever. Changed to 300s (5 minutes).quickstart.pynow usestimeout=30on the command call to prevent indefinite blocking.