Publish Connectors concept doc#179
Conversation
pnpm 11 errors on unapproved postinstall scripts (ERR_PNPM_IGNORED_BUILDS), which has been failing CI on every branch. Allow-list the three packages that need to run install/postinstall: cypress, esbuild, sharp.
pnpm 11 reads onlyBuiltDependencies from pnpm-workspace.yaml, not from the package.json pnpm field — the previous attempt left CI failing with ERR_PNPM_IGNORED_BUILDS.
pnpm 11 renamed the build-approval setting from onlyBuiltDependencies to allowBuilds (a map of package -> bool). Without this, install fails with ERR_PNPM_IGNORED_BUILDS.
The build approval list lives in pnpm-workspace.yaml, so the Dockerfile needs to copy it alongside package.json — otherwise the Docker build fails with ERR_PNPM_IGNORED_BUILDS even though GitHub Actions' Build step succeeds.
Preview Deployment
Commit: |
Lighthouse Results
|
E2E Test Results✅ Tests success Ran against: https://pr-179-superfly-sprites-docs.fly.dev |
| allowBuilds: | ||
| cypress: true | ||
| esbuild: true | ||
| sharp: true |
There was a problem hiding this comment.
allowBuilds isn't a pnpm setting, so this won't actually unblock CI. The key that resolves ERR_PNPM_IGNORED_BUILDS is onlyBuiltDependencies, and it takes a list:
onlyBuiltDependencies:
- cypress
- esbuild
- sharp(The PR description mentions pnpm.onlyBuiltDependencies, so the intent was right, just the wrong key/shape landed in the file.) The Dockerfile COPY change is correct and still needed.
There was a problem hiding this comment.
Oh thanks for catching that! Fixing it.
|
Suggest adding a Concepts group after "Getting Started" in {
label: 'Concepts',
items: [
{ label: 'Connectors', slug: 'concepts/connectors' },
],
},The other concept docs ( |
kcmartin
left a comment
kcmartin
left a comment
There was a problem hiding this comment.
Left a suggested copy change, a comment, and and a suggestion about the sidebar section for this page
Co-authored-by: Kristin Martin <kcmartin@users.noreply.github.com>
- pnpm-workspace.yaml: the correct pnpm 11 key is onlyBuiltDependencies (list of names), not allowBuilds. Builds were green by coincidence, not because the scripts were running. - sidebar: add a Concepts group with Connectors, between Getting Started and CLI Reference. Other concept docs are still draft and will slot in here as they publish.
pnpm 11.0 removed onlyBuiltDependencies entirely and replaced it with allowBuilds (a map of package name -> bool). CI uses pnpm 11.1.2, where the old key is silently ignored and install errors with ERR_PNPM_IGNORED_BUILDS.
|
@kcmartin thank you so much for your feedback! Addressed :) |
2 participants
Summary
draft: truefrontmatter.allowed_endpoints/blocked_endpoints. Links readers to the public Connectors API reference (added in superfly/sprites-api#579).pnpm.onlyBuiltDependenciesforcypress,esbuild, andsharp. pnpm 11 was erroring on every recent CI run (ERR_PNPM_IGNORED_BUILDS); this allow-lists the three packages that need to run postinstall scripts.Test plan
pnpm installfor all branches before this fix).pnpm devand visit http://localhost:4321/concepts/connectors/ to confirm the page renders and appears in the sidebar under Concepts.