Skip to content

fix: add safety check for clipboard usage #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
harbournick merged 2 commits into from
Sep 3, 2025
Merged

fix: add safety check for clipboard usage #859

harbournick merged 2 commits into from
Sep 3, 2025

Conversation

@palmer-cl
Copy link
Collaborator

@palmer-cl palmer-cl commented Sep 3, 2025

  • Adds checks for clipboard read access
  • Fails safely to no content in clipboard if permissions are not granted or navigator does not exist

harbournick
harbournick requested changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@harbournick harbournick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls add a test file next to clipboardUtils.js (clipboardUtils.test.js) with some tests to cover this function? also let's include one test case for the current bug - thank you!

@harbournick harbournick added the bug label Sep 3, 2025
@harbournick harbournick linked an issue Sep 3, 2025 that may be closed by this pull request
why sometimes slash-menu-items doesn't exist #781
Closed
@palmer-cl
Copy link
Collaborator Author

palmer-cl commented Sep 3, 2025

Tests added, also removed some unused utils

harbournick
harbournick approved these changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick changed the base branch from develop to main September 3, 2025 05:02
@harbournick harbournick merged commit bfca96e into main Sep 3, 2025
@harbournick harbournick deleted the fix/safe-clipboard-permissions branch September 3, 2025 05:03
harbournick pushed a commit that referenced this pull request Sep 3, 2025
@semantic-release-bot
chore(release): 0.16.0-next.8 [skip ci]
6b71db2 
# [0.16.0-next.8](v0.16.0-next.7...v0.16.0-next.8) (2025-09-03)

### Bug Fixes

* add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e))
@harbournick
Copy link
Collaborator

harbournick commented Sep 3, 2025

🎉 This PR is included in version 0.16.0-next.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

harbournick pushed a commit that referenced this pull request Sep 3, 2025
@semantic-release-bot
chore(release): 0.16.1 [skip ci]
e9c331c 
## [0.16.1](v0.16.0...v0.16.1) (2025-09-03)

### Bug Fixes

* add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e))
* correct syntax in release workflow for semantic-release command ([3e6376e](3e6376e))
* dispatch tracked changes transaction only once at import ([31ecec7](31ecec7))
* imports encoded in utf-16 break DocxZipper ([6d09115](6d09115))
* imports encoded in utf-16 break DocxZipper ([9bc488d](9bc488d))
* imports encoded in utf-16 break DocxZipper ([#860](#860)) ([3a1be24](3a1be24))
* semantic release range ([505e27b](505e27b))
* update release naming pattern in .releaserc.json for better version matching ([1fda655](1fda655))
@harbournick
Copy link
Collaborator

harbournick commented Sep 3, 2025

🎉 This PR is included in version 0.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

harbournick pushed a commit that referenced this pull request Sep 9, 2025
@semantic-release-bot
chore(release): 0.16.0 [skip ci]
d5b0b44 
# [0.16.0](v0.15.18...v0.16.0) (2025-09-09)

### Bug Fixes

* add processing for line-height defined in px ([#880](#880)) ([3b61275](3b61275))
* add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e))
* additional fixes to list indent/outdent, split list, toggle list, types and more tests ([02e6cd9](02e6cd9))
* backspaceNextToList, toggleList and tests ([8b33258](8b33258))
* closing dropdown after clicking again ([#835](#835)) ([88ff88d](88ff88d))
* correct syntax in release workflow for semantic-release command ([3e6376e](3e6376e))
* createNewList in input rule to fix new list in tables, lint ([aa79655](aa79655))
* definition possibly missing name key, add jsdoc ([bb714f1](bb714f1))
* dispatch tracked changes transaction only once at import ([31ecec7](31ecec7))
* do not deploy next on oracle or yjs changes ([a02cf33](a02cf33))
* highlight selected value in font dropdowns ([#869](#869)) ([4a30f59](4a30f59))
* images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e))
* imports encoded in utf-16 break DocxZipper ([#860](#860)) ([3a1be24](3a1be24))
* include package lock on tests folder ([#845](#845)) ([1409d02](1409d02))
* insertContentAt fails if new line characters (\n) inserted ([dd60d91](dd60d91))
* insertContentAt for html ([f6c53d3](f6c53d3))
* inserting html with heading tags does not render as expected (HAR-10430) ([#874](#874)) ([bba5074](bba5074))
* install http server ([#846](#846)) ([1a6e684](1a6e684))
* **internal:** remove pdfjs from build ([#843](#843)) ([021b2c1](021b2c1))
* japanese list numbering ([#882](#882)) ([d256a48](d256a48))
* regex improvements ([ee0333b](ee0333b))
* remove footer line length breaking deployments ([04766cd](04766cd))
* restore stored marks if they exist ([#863](#863)) ([0a2860e](0a2860e))
* restore stored marks if they exist ([#863](#863)) ([1961e5f](1961e5f))
* splitListItem if there are images or other atom nodes in list item, fix tests ([#878](#878)) ([535390f](535390f))
* **table:** add support for table row w:cantSplit ([#890](#890)) ([3467ad5](3467ad5))
* test ([8572b8a](8572b8a))
* test ([65126fd](65126fd))
* test ([42cb383](42cb383))
* test next release ([c3ac7d0](c3ac7d0))
* toggle list ([770998a](770998a))
* toggle list for multiple nodes and active selection ([69b3a1b](69b3a1b))
* toggle list inside tables ([091df80](091df80))
* update condition checks for screenshot updates in CI workflow ([e17fdf0](e17fdf0))

### Features

* add custom toolbar button example (HAR-10436) ([#868](#868)) ([c4fd4d5](c4fd4d5))
* add support for paragraph borders ([#862](#862)) ([2f98c07](2f98c07))
* begin v0.18 development ([ed5030f](ed5030f))
* enable dispatching example apps tests ([#844](#844)) ([8b2bc73](8b2bc73))
* filter out ooxml tags cli to highest priority namespaces ([23b1efa](23b1efa))
* ignore specific docx nodes during import ([#909](#909)) ([0a99a09](0a99a09))
harbournick pushed a commit that referenced this pull request Sep 9, 2025
@semantic-release-bot
chore(release): 0.16.0 [skip ci]
1e536ed 
# [0.16.0](v0.15.18...v0.16.0) (2025-09-09)

### Bug Fixes

* add processing for line-height defined in px ([#880](#880)) ([3b61275](3b61275))
* add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e))
* additional fixes to list indent/outdent, split list, toggle list, types and more tests ([02e6cd9](02e6cd9))
* backspaceNextToList, toggleList and tests ([8b33258](8b33258))
* closing dropdown after clicking again ([#835](#835)) ([88ff88d](88ff88d))
* correct syntax in release workflow for semantic-release command ([3e6376e](3e6376e))
* createNewList in input rule to fix new list in tables, lint ([aa79655](aa79655))
* definition possibly missing name key, add jsdoc ([bb714f1](bb714f1))
* dispatch tracked changes transaction only once at import ([31ecec7](31ecec7))
* do not deploy next on oracle or yjs changes ([a02cf33](a02cf33))
* highlight selected value in font dropdowns ([#869](#869)) ([4a30f59](4a30f59))
* images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e))
* imports encoded in utf-16 break DocxZipper ([#860](#860)) ([3a1be24](3a1be24))
* include package lock on tests folder ([#845](#845)) ([1409d02](1409d02))
* insertContentAt fails if new line characters (\n) inserted ([dd60d91](dd60d91))
* insertContentAt for html ([f6c53d3](f6c53d3))
* inserting html with heading tags does not render as expected (HAR-10430) ([#874](#874)) ([bba5074](bba5074))
* install http server ([#846](#846)) ([1a6e684](1a6e684))
* **internal:** remove pdfjs from build ([#843](#843)) ([021b2c1](021b2c1))
* japanese list numbering ([#882](#882)) ([d256a48](d256a48))
* regex improvements ([ee0333b](ee0333b))
* remove footer line length breaking deployments ([04766cd](04766cd))
* restore stored marks if they exist ([#863](#863)) ([0a2860e](0a2860e))
* restore stored marks if they exist ([#863](#863)) ([1961e5f](1961e5f))
* splitListItem if there are images or other atom nodes in list item, fix tests ([#878](#878)) ([535390f](535390f))
* **table:** add support for table row w:cantSplit ([#890](#890)) ([3467ad5](3467ad5))
* test ([8572b8a](8572b8a))
* test ([65126fd](65126fd))
* test ([42cb383](42cb383))
* test next release ([c3ac7d0](c3ac7d0))
* toggle list ([770998a](770998a))
* toggle list for multiple nodes and active selection ([69b3a1b](69b3a1b))
* toggle list inside tables ([091df80](091df80))
* update condition checks for screenshot updates in CI workflow ([e17fdf0](e17fdf0))

### Features

* add custom toolbar button example (HAR-10436) ([#868](#868)) ([c4fd4d5](c4fd4d5))
* add support for paragraph borders ([#862](#862)) ([2f98c07](2f98c07))
* begin v0.18 development ([ed5030f](ed5030f))
* enable dispatching example apps tests ([#844](#844)) ([8b2bc73](8b2bc73))
* filter out ooxml tags cli to highest priority namespaces ([23b1efa](23b1efa))
* ignore specific docx nodes during import ([#909](#909)) ([0a99a09](0a99a09))
* new release cycle after version sync ([eb9684a](eb9684a))
harbournick pushed a commit that referenced this pull request Sep 9, 2025
@semantic-release-bot @harbournick
chore(release): 0.16.0 [skip ci]
92d055a 
# [0.16.0](v0.15.18...v0.16.0) (2025-09-09)

### Bug Fixes

* add processing for line-height defined in px ([#880](#880)) ([3b61275](3b61275))
* add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e))
* additional fixes to list indent/outdent, split list, toggle list, types and more tests ([02e6cd9](02e6cd9))
* backspaceNextToList, toggleList and tests ([8b33258](8b33258))
* closing dropdown after clicking again ([#835](#835)) ([88ff88d](88ff88d))
* correct syntax in release workflow for semantic-release command ([3e6376e](3e6376e))
* createNewList in input rule to fix new list in tables, lint ([aa79655](aa79655))
* definition possibly missing name key, add jsdoc ([bb714f1](bb714f1))
* dispatch tracked changes transaction only once at import ([31ecec7](31ecec7))
* do not deploy next on oracle or yjs changes ([a02cf33](a02cf33))
* highlight selected value in font dropdowns ([#869](#869)) ([4a30f59](4a30f59))
* images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e))
* imports encoded in utf-16 break DocxZipper ([#860](#860)) ([3a1be24](3a1be24))
* include package lock on tests folder ([#845](#845)) ([1409d02](1409d02))
* insertContentAt fails if new line characters (\n) inserted ([dd60d91](dd60d91))
* insertContentAt for html ([f6c53d3](f6c53d3))
* inserting html with heading tags does not render as expected (HAR-10430) ([#874](#874)) ([bba5074](bba5074))
* install http server ([#846](#846)) ([1a6e684](1a6e684))
* **internal:** remove pdfjs from build ([#843](#843)) ([021b2c1](021b2c1))
* japanese list numbering ([#882](#882)) ([d256a48](d256a48))
* regex improvements ([ee0333b](ee0333b))
* remove footer line length breaking deployments ([04766cd](04766cd))
* restore stored marks if they exist ([#863](#863)) ([0a2860e](0a2860e))
* restore stored marks if they exist ([#863](#863)) ([1961e5f](1961e5f))
* splitListItem if there are images or other atom nodes in list item, fix tests ([#878](#878)) ([535390f](535390f))
* **table:** add support for table row w:cantSplit ([#890](#890)) ([3467ad5](3467ad5))
* test ([8572b8a](8572b8a))
* test ([65126fd](65126fd))
* test ([42cb383](42cb383))
* test next release ([c3ac7d0](c3ac7d0))
* toggle list ([770998a](770998a))
* toggle list for multiple nodes and active selection ([69b3a1b](69b3a1b))
* toggle list inside tables ([091df80](091df80))
* update condition checks for screenshot updates in CI workflow ([e17fdf0](e17fdf0))

### Features

* add custom toolbar button example (HAR-10436) ([#868](#868)) ([c4fd4d5](c4fd4d5))
* add support for paragraph borders ([#862](#862)) ([2f98c07](2f98c07))
* begin v0.18 development ([ed5030f](ed5030f))
* enable dispatching example apps tests ([#844](#844)) ([8b2bc73](8b2bc73))
* filter out ooxml tags cli to highest priority namespaces ([23b1efa](23b1efa))
* ignore specific docx nodes during import ([#909](#909)) ([0a99a09](0a99a09))
harbournick pushed a commit that referenced this pull request Sep 9, 2025
@semantic-release-bot @harbournick
chore(release): 0.16.0 [skip ci]
805b915 
# [0.16.0](v0.15.18...v0.16.0) (2025-09-09)

### Bug Fixes

* add processing for line-height defined in px ([#880](#880)) ([3b61275](3b61275))
* add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e))
* additional fixes to list indent/outdent, split list, toggle list, types and more tests ([02e6cd9](02e6cd9))
* backspaceNextToList, toggleList and tests ([8b33258](8b33258))
* closing dropdown after clicking again ([#835](#835)) ([88ff88d](88ff88d))
* correct syntax in release workflow for semantic-release command ([3e6376e](3e6376e))
* createNewList in input rule to fix new list in tables, lint ([aa79655](aa79655))
* definition possibly missing name key, add jsdoc ([bb714f1](bb714f1))
* dispatch tracked changes transaction only once at import ([31ecec7](31ecec7))
* do not deploy next on oracle or yjs changes ([a02cf33](a02cf33))
* highlight selected value in font dropdowns ([#869](#869)) ([4a30f59](4a30f59))
* images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e))
* imports encoded in utf-16 break DocxZipper ([#860](#860)) ([3a1be24](3a1be24))
* include package lock on tests folder ([#845](#845)) ([1409d02](1409d02))
* insertContentAt fails if new line characters (\n) inserted ([dd60d91](dd60d91))
* insertContentAt for html ([f6c53d3](f6c53d3))
* inserting html with heading tags does not render as expected (HAR-10430) ([#874](#874)) ([bba5074](bba5074))
* install http server ([#846](#846)) ([1a6e684](1a6e684))
* **internal:** remove pdfjs from build ([#843](#843)) ([021b2c1](021b2c1))
* japanese list numbering ([#882](#882)) ([d256a48](d256a48))
* regex improvements ([ee0333b](ee0333b))
* remove footer line length breaking deployments ([04766cd](04766cd))
* restore stored marks if they exist ([#863](#863)) ([0a2860e](0a2860e))
* restore stored marks if they exist ([#863](#863)) ([1961e5f](1961e5f))
* splitListItem if there are images or other atom nodes in list item, fix tests ([#878](#878)) ([535390f](535390f))
* **table:** add support for table row w:cantSplit ([#890](#890)) ([3467ad5](3467ad5))
* test ([8572b8a](8572b8a))
* test ([65126fd](65126fd))
* test ([42cb383](42cb383))
* test next release ([c3ac7d0](c3ac7d0))
* toggle list ([770998a](770998a))
* toggle list for multiple nodes and active selection ([69b3a1b](69b3a1b))
* toggle list inside tables ([091df80](091df80))
* update condition checks for screenshot updates in CI workflow ([e17fdf0](e17fdf0))

### Features

* add custom toolbar button example (HAR-10436) ([#868](#868)) ([c4fd4d5](c4fd4d5))
* add support for paragraph borders ([#862](#862)) ([2f98c07](2f98c07))
* begin v0.18 development ([ed5030f](ed5030f))
* enable dispatching example apps tests ([#844](#844)) ([8b2bc73](8b2bc73))
* filter out ooxml tags cli to highest priority namespaces ([23b1efa](23b1efa))
* ignore specific docx nodes during import ([#909](#909)) ([0a99a09](0a99a09))
* new release cycle after version sync ([eb9684a](eb9684a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harbournick harbournick harbournick approved these changes

Assignees

@palmer-cl palmer-cl

Labels

ready for review released on @latest released on @next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

why sometimes slash-menu-items doesn't exist

3 participants

@palmer-cl @harbournick