Skip to content

fix(internal): remove pdfjs from build #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 2 commits into from
Sep 2, 2025
Merged

fix(internal): remove pdfjs from build #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28c1d5f
fix(internal): remove pdfjs from build
artem-harbour Aug 28, 2025
e49c4e6
chore: remove extra comma
harbournick Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/superdoc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
},
"peerDependencies": {
"@hocuspocus/provider": "^2.13.6",
"pdfjs-dist": "4.3.136",
"pdfjs-dist": ">=4.3.136 <=4.6.82",
"y-prosemirror": "^1.2.12",
"yjs": "13.6.19"
},
Expand All @@ -77,6 +77,7 @@
"pdfjs-dist": "4.3.136",
"postcss-nested": "^6.0.1",
"postcss-nested-import": "^1.3.0",
"postcss-prefixwrap": "^1.56.2",
"typescript": "^5.7.3",
"vite": "^6.3.5",
"vitest": "^3.2.4",
Expand Down
11 changes: 10 additions & 1 deletion packages/superdoc/postcss.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
// packages/superdoc/src/components/PdfViewer/PdfViewer.vue
const PDF_VIEWER_CLASS = '.superdoc-pdf-viewer';

module.exports = {
plugins: [
require('postcss-nested'),
require('postcss-nested-import'),
// https://github.com/dbtedman/postcss-prefixwrap
// This is necessary for pdf.js style scoping.
require('postcss-prefixwrap')(PDF_VIEWER_CLASS, {
whitelist: ['pdf-viewer.css'],
ignoredSelectors: [],
prefixRootTags: false,
}),
]
}
8 changes: 7 additions & 1 deletion packages/superdoc/src/SuperDoc.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ import {
computed,
reactive,
watch,
defineAsyncComponent,
} from 'vue';
import { NMessageProvider } from 'naive-ui';
import { storeToRefs } from 'pinia';

import PdfViewer from './components/PdfViewer/PdfViewer.vue';
import CommentsLayer from './components/CommentsLayer/CommentsLayer.vue';
import CommentDialog from '@superdoc/components/CommentsLayer/CommentDialog.vue';
import FloatingComments from '@superdoc/components/CommentsLayer/FloatingComments.vue';
Expand All @@ -35,6 +35,9 @@ import AiLayer from './components/AiLayer/AiLayer.vue';
import { useSelectedText } from './composables/use-selected-text';
import { useAi } from './composables/use-ai';
import { useHighContrastMode } from './composables/use-high-contrast-mode';

const PdfViewer = defineAsyncComponent(() => import('./components/PdfViewer/PdfViewer.vue'));

// Stores
const superdocStore = useSuperdocStore();
const commentsStore = useCommentsStore();
Expand Down Expand Up @@ -104,6 +107,8 @@ const {
// Hrbr Fields
const hrbrFieldsLayer = ref(null);

const pdfConfig = proxy.$superdoc.config.modules?.pdf || {};

const handleDocumentReady = (documentId, container) => {
const doc = getDocument(documentId);
doc.isReady = true;
Expand Down Expand Up @@ -622,6 +627,7 @@ watch(getFloatingComments, () => {
<PdfViewer
v-if="doc.type === PDF"
:document-data="doc"
:config="pdfConfig"
@selection-change="handleSelectionChange"
@ready="handleDocumentReady"
@page-loaded="handlePageReady"
Expand Down
Loading
Loading