fix: images are missing for the document in edit mode #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harbournick
requested changes
Sep 1, 2025
Collaborator
harbournick
left a comment
harbournick
left a comment
There was a problem hiding this comment.
Can you double check export as well? seems the top image does not export correctly
Also: Can we add import/export tests to:
- Cover the case we are fixing (test should fail prior to this fix, should pass with fix)
- cover the export not working currently for top image
chittolinag
requested changes
Sep 1, 2025
Contributor
There was a problem hiding this comment.
Hey @VladaHarbour ! Not sure if this is the same thing that @harbournick mentioned, but I did notice that a few documents are failing to load. I'll send you more details via DM.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
VladaHarbour
force-pushed
the
ide-7_images
branch
from
d263e11 to
de87295
Compare
harbournick
pushed a commit
that referenced
this pull request
Sep 2, 2025
# [0.16.0-next.3](v0.16.0-next.2...v0.16.0-next.3) (2025-09-02) ### Bug Fixes * images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e))
Collaborator
|
🎉 This PR is included in version 0.16.0-next.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
harbournick
pushed a commit
that referenced
this pull request
Sep 3, 2025
# [0.16.0](v0.15.18...v0.16.0) (2025-09-03) ### Bug Fixes * additional fixes to list indent/outdent, split list, toggle list, types and more tests ([02e6cd9](02e6cd9)) * backspaceNextToList, toggleList and tests ([8b33258](8b33258)) * closing dropdown after clicking again ([#835](#835)) ([88ff88d](88ff88d)) * definition possibly missing name key, add jsdoc ([bb714f1](bb714f1)) * images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e)) * include package lock on tests folder ([#845](#845)) ([1409d02](1409d02)) * insertContentAt fails if new line characters (\n) inserted ([dd60d91](dd60d91)) * install http server ([#846](#846)) ([1a6e684](1a6e684)) * **internal:** remove pdfjs from build ([#843](#843)) ([021b2c1](021b2c1)) * remove footer line length breaking deployments ([04766cd](04766cd)) * toggle list ([770998a](770998a)) * update condition checks for screenshot updates in CI workflow ([e17fdf0](e17fdf0)) ### Features * enable dispatching example apps tests ([#844](#844)) ([8b2bc73](8b2bc73)) * filter out ooxml tags cli to highest priority namespaces ([23b1efa](23b1efa))
harbournick
pushed a commit
that referenced
this pull request
Sep 9, 2025
# [0.16.0](v0.15.18...v0.16.0) (2025-09-09) ### Bug Fixes * add processing for line-height defined in px ([#880](#880)) ([3b61275](3b61275)) * add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e)) * additional fixes to list indent/outdent, split list, toggle list, types and more tests ([02e6cd9](02e6cd9)) * backspaceNextToList, toggleList and tests ([8b33258](8b33258)) * closing dropdown after clicking again ([#835](#835)) ([88ff88d](88ff88d)) * correct syntax in release workflow for semantic-release command ([3e6376e](3e6376e)) * createNewList in input rule to fix new list in tables, lint ([aa79655](aa79655)) * definition possibly missing name key, add jsdoc ([bb714f1](bb714f1)) * dispatch tracked changes transaction only once at import ([31ecec7](31ecec7)) * do not deploy next on oracle or yjs changes ([a02cf33](a02cf33)) * highlight selected value in font dropdowns ([#869](#869)) ([4a30f59](4a30f59)) * images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e)) * imports encoded in utf-16 break DocxZipper ([#860](#860)) ([3a1be24](3a1be24)) * include package lock on tests folder ([#845](#845)) ([1409d02](1409d02)) * insertContentAt fails if new line characters (\n) inserted ([dd60d91](dd60d91)) * insertContentAt for html ([f6c53d3](f6c53d3)) * inserting html with heading tags does not render as expected (HAR-10430) ([#874](#874)) ([bba5074](bba5074)) * install http server ([#846](#846)) ([1a6e684](1a6e684)) * **internal:** remove pdfjs from build ([#843](#843)) ([021b2c1](021b2c1)) * japanese list numbering ([#882](#882)) ([d256a48](d256a48)) * regex improvements ([ee0333b](ee0333b)) * remove footer line length breaking deployments ([04766cd](04766cd)) * restore stored marks if they exist ([#863](#863)) ([0a2860e](0a2860e)) * restore stored marks if they exist ([#863](#863)) ([1961e5f](1961e5f)) * splitListItem if there are images or other atom nodes in list item, fix tests ([#878](#878)) ([535390f](535390f)) * **table:** add support for table row w:cantSplit ([#890](#890)) ([3467ad5](3467ad5)) * test ([8572b8a](8572b8a)) * test ([65126fd](65126fd)) * test ([42cb383](42cb383)) * test next release ([c3ac7d0](c3ac7d0)) * toggle list ([770998a](770998a)) * toggle list for multiple nodes and active selection ([69b3a1b](69b3a1b)) * toggle list inside tables ([091df80](091df80)) * update condition checks for screenshot updates in CI workflow ([e17fdf0](e17fdf0)) ### Features * add custom toolbar button example (HAR-10436) ([#868](#868)) ([c4fd4d5](c4fd4d5)) * add support for paragraph borders ([#862](#862)) ([2f98c07](2f98c07)) * begin v0.18 development ([ed5030f](ed5030f)) * enable dispatching example apps tests ([#844](#844)) ([8b2bc73](8b2bc73)) * filter out ooxml tags cli to highest priority namespaces ([23b1efa](23b1efa)) * ignore specific docx nodes during import ([#909](#909)) ([0a99a09](0a99a09))
harbournick
pushed a commit
that referenced
this pull request
Sep 9, 2025
# [0.16.0](v0.15.18...v0.16.0) (2025-09-09) ### Bug Fixes * add processing for line-height defined in px ([#880](#880)) ([3b61275](3b61275)) * add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e)) * additional fixes to list indent/outdent, split list, toggle list, types and more tests ([02e6cd9](02e6cd9)) * backspaceNextToList, toggleList and tests ([8b33258](8b33258)) * closing dropdown after clicking again ([#835](#835)) ([88ff88d](88ff88d)) * correct syntax in release workflow for semantic-release command ([3e6376e](3e6376e)) * createNewList in input rule to fix new list in tables, lint ([aa79655](aa79655)) * definition possibly missing name key, add jsdoc ([bb714f1](bb714f1)) * dispatch tracked changes transaction only once at import ([31ecec7](31ecec7)) * do not deploy next on oracle or yjs changes ([a02cf33](a02cf33)) * highlight selected value in font dropdowns ([#869](#869)) ([4a30f59](4a30f59)) * images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e)) * imports encoded in utf-16 break DocxZipper ([#860](#860)) ([3a1be24](3a1be24)) * include package lock on tests folder ([#845](#845)) ([1409d02](1409d02)) * insertContentAt fails if new line characters (\n) inserted ([dd60d91](dd60d91)) * insertContentAt for html ([f6c53d3](f6c53d3)) * inserting html with heading tags does not render as expected (HAR-10430) ([#874](#874)) ([bba5074](bba5074)) * install http server ([#846](#846)) ([1a6e684](1a6e684)) * **internal:** remove pdfjs from build ([#843](#843)) ([021b2c1](021b2c1)) * japanese list numbering ([#882](#882)) ([d256a48](d256a48)) * regex improvements ([ee0333b](ee0333b)) * remove footer line length breaking deployments ([04766cd](04766cd)) * restore stored marks if they exist ([#863](#863)) ([0a2860e](0a2860e)) * restore stored marks if they exist ([#863](#863)) ([1961e5f](1961e5f)) * splitListItem if there are images or other atom nodes in list item, fix tests ([#878](#878)) ([535390f](535390f)) * **table:** add support for table row w:cantSplit ([#890](#890)) ([3467ad5](3467ad5)) * test ([8572b8a](8572b8a)) * test ([65126fd](65126fd)) * test ([42cb383](42cb383)) * test next release ([c3ac7d0](c3ac7d0)) * toggle list ([770998a](770998a)) * toggle list for multiple nodes and active selection ([69b3a1b](69b3a1b)) * toggle list inside tables ([091df80](091df80)) * update condition checks for screenshot updates in CI workflow ([e17fdf0](e17fdf0)) ### Features * add custom toolbar button example (HAR-10436) ([#868](#868)) ([c4fd4d5](c4fd4d5)) * add support for paragraph borders ([#862](#862)) ([2f98c07](2f98c07)) * begin v0.18 development ([ed5030f](ed5030f)) * enable dispatching example apps tests ([#844](#844)) ([8b2bc73](8b2bc73)) * filter out ooxml tags cli to highest priority namespaces ([23b1efa](23b1efa)) * ignore specific docx nodes during import ([#909](#909)) ([0a99a09](0a99a09)) * new release cycle after version sync ([eb9684a](eb9684a))
harbournick
pushed a commit
that referenced
this pull request
Sep 9, 2025
# [0.16.0](v0.15.18...v0.16.0) (2025-09-09) ### Bug Fixes * add processing for line-height defined in px ([#880](#880)) ([3b61275](3b61275)) * add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e)) * additional fixes to list indent/outdent, split list, toggle list, types and more tests ([02e6cd9](02e6cd9)) * backspaceNextToList, toggleList and tests ([8b33258](8b33258)) * closing dropdown after clicking again ([#835](#835)) ([88ff88d](88ff88d)) * correct syntax in release workflow for semantic-release command ([3e6376e](3e6376e)) * createNewList in input rule to fix new list in tables, lint ([aa79655](aa79655)) * definition possibly missing name key, add jsdoc ([bb714f1](bb714f1)) * dispatch tracked changes transaction only once at import ([31ecec7](31ecec7)) * do not deploy next on oracle or yjs changes ([a02cf33](a02cf33)) * highlight selected value in font dropdowns ([#869](#869)) ([4a30f59](4a30f59)) * images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e)) * imports encoded in utf-16 break DocxZipper ([#860](#860)) ([3a1be24](3a1be24)) * include package lock on tests folder ([#845](#845)) ([1409d02](1409d02)) * insertContentAt fails if new line characters (\n) inserted ([dd60d91](dd60d91)) * insertContentAt for html ([f6c53d3](f6c53d3)) * inserting html with heading tags does not render as expected (HAR-10430) ([#874](#874)) ([bba5074](bba5074)) * install http server ([#846](#846)) ([1a6e684](1a6e684)) * **internal:** remove pdfjs from build ([#843](#843)) ([021b2c1](021b2c1)) * japanese list numbering ([#882](#882)) ([d256a48](d256a48)) * regex improvements ([ee0333b](ee0333b)) * remove footer line length breaking deployments ([04766cd](04766cd)) * restore stored marks if they exist ([#863](#863)) ([0a2860e](0a2860e)) * restore stored marks if they exist ([#863](#863)) ([1961e5f](1961e5f)) * splitListItem if there are images or other atom nodes in list item, fix tests ([#878](#878)) ([535390f](535390f)) * **table:** add support for table row w:cantSplit ([#890](#890)) ([3467ad5](3467ad5)) * test ([8572b8a](8572b8a)) * test ([65126fd](65126fd)) * test ([42cb383](42cb383)) * test next release ([c3ac7d0](c3ac7d0)) * toggle list ([770998a](770998a)) * toggle list for multiple nodes and active selection ([69b3a1b](69b3a1b)) * toggle list inside tables ([091df80](091df80)) * update condition checks for screenshot updates in CI workflow ([e17fdf0](e17fdf0)) ### Features * add custom toolbar button example (HAR-10436) ([#868](#868)) ([c4fd4d5](c4fd4d5)) * add support for paragraph borders ([#862](#862)) ([2f98c07](2f98c07)) * begin v0.18 development ([ed5030f](ed5030f)) * enable dispatching example apps tests ([#844](#844)) ([8b2bc73](8b2bc73)) * filter out ooxml tags cli to highest priority namespaces ([23b1efa](23b1efa)) * ignore specific docx nodes during import ([#909](#909)) ([0a99a09](0a99a09))
harbournick
pushed a commit
that referenced
this pull request
Sep 9, 2025
# [0.16.0](v0.15.18...v0.16.0) (2025-09-09) ### Bug Fixes * add processing for line-height defined in px ([#880](#880)) ([3b61275](3b61275)) * add safety check for clipboard usage ([#859](#859)) ([bfca96e](bfca96e)) * additional fixes to list indent/outdent, split list, toggle list, types and more tests ([02e6cd9](02e6cd9)) * backspaceNextToList, toggleList and tests ([8b33258](8b33258)) * closing dropdown after clicking again ([#835](#835)) ([88ff88d](88ff88d)) * correct syntax in release workflow for semantic-release command ([3e6376e](3e6376e)) * createNewList in input rule to fix new list in tables, lint ([aa79655](aa79655)) * definition possibly missing name key, add jsdoc ([bb714f1](bb714f1)) * dispatch tracked changes transaction only once at import ([31ecec7](31ecec7)) * do not deploy next on oracle or yjs changes ([a02cf33](a02cf33)) * highlight selected value in font dropdowns ([#869](#869)) ([4a30f59](4a30f59)) * images are missing for the document in edit mode ([#831](#831)) ([a9af47e](a9af47e)) * imports encoded in utf-16 break DocxZipper ([#860](#860)) ([3a1be24](3a1be24)) * include package lock on tests folder ([#845](#845)) ([1409d02](1409d02)) * insertContentAt fails if new line characters (\n) inserted ([dd60d91](dd60d91)) * insertContentAt for html ([f6c53d3](f6c53d3)) * inserting html with heading tags does not render as expected (HAR-10430) ([#874](#874)) ([bba5074](bba5074)) * install http server ([#846](#846)) ([1a6e684](1a6e684)) * **internal:** remove pdfjs from build ([#843](#843)) ([021b2c1](021b2c1)) * japanese list numbering ([#882](#882)) ([d256a48](d256a48)) * regex improvements ([ee0333b](ee0333b)) * remove footer line length breaking deployments ([04766cd](04766cd)) * restore stored marks if they exist ([#863](#863)) ([0a2860e](0a2860e)) * restore stored marks if they exist ([#863](#863)) ([1961e5f](1961e5f)) * splitListItem if there are images or other atom nodes in list item, fix tests ([#878](#878)) ([535390f](535390f)) * **table:** add support for table row w:cantSplit ([#890](#890)) ([3467ad5](3467ad5)) * test ([8572b8a](8572b8a)) * test ([65126fd](65126fd)) * test ([42cb383](42cb383)) * test next release ([c3ac7d0](c3ac7d0)) * toggle list ([770998a](770998a)) * toggle list for multiple nodes and active selection ([69b3a1b](69b3a1b)) * toggle list inside tables ([091df80](091df80)) * update condition checks for screenshot updates in CI workflow ([e17fdf0](e17fdf0)) ### Features * add custom toolbar button example (HAR-10436) ([#868](#868)) ([c4fd4d5](c4fd4d5)) * add support for paragraph borders ([#862](#862)) ([2f98c07](2f98c07)) * begin v0.18 development ([ed5030f](ed5030f)) * enable dispatching example apps tests ([#844](#844)) ([8b2bc73](8b2bc73)) * filter out ooxml tags cli to highest priority namespaces ([23b1efa](23b1efa)) * ignore specific docx nodes during import ([#909](#909)) ([0a99a09](0a99a09)) * new release cycle after version sync ([eb9684a](eb9684a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.