feat(release): add superdoc to stable orchestrator (chain-aware fail-stop)#3204
Open
caio-pizzol wants to merge 1 commit intomainfrom
Open
feat(release): add superdoc to stable orchestrator (chain-aware fail-stop)#3204caio-pizzol wants to merge 1 commit intomainfrom
caio-pizzol wants to merge 1 commit intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e3439340b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
caio-pizzol
force-pushed
the
release-orchestrator-pr2-superdoc
branch
2 times, most recently
from
d1570ac to
ecba8c3
Compare
…stop) Adds superdoc to the stable orchestrator so the v* tag drives docs-stable promotion in the same workflow that releases tools, removing the cross- workflow concurrency-eviction problem for stable superdoc releases. The orchestrator now groups packages by chain. Within a chain, fail-stop applies as before (CLI failure skips SDK/MCP). Across chains, failures are independent: a tools failure does not skip superdoc and vice versa. Workflow rewiring: - release-superdoc.yml stops auto-firing on stable; main pushes still publish prereleases, and workflow_dispatch is preserved for recovery. - promote-stable-docs.yml triggers off release-stable.yml. The conclusion gate now accepts both success and failure - a tools-chain failure that follows a successful superdoc release should still promote docs. The inner git-tag detection (compare tags merged at the run's head_sha vs origin/stable) remains the source of truth, so tools-only runs still leave docs-stable alone. - release-stable.yml header comments + step name updated to reflect the broader scope; the workflow's name field is unchanged so the existing workflow_run trigger and concurrency group continue to match. A rename is best as a follow-up cleanup PR. Stacked on #3201 (descriptor refactor).
caio-pizzol
force-pushed
the
release-orchestrator-pr2-superdoc
branch
from
ecba8c3 to
bea5ba8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3201. Brings superdoc into the stable release orchestrator so its v* tag drives docs-stable promotion in the same workflow that releases tools, eliminating the cross-workflow concurrency-eviction problem for stable superdoc releases.
The orchestrator now groups packages by `chain`. Within a chain, fail-stop applies (CLI failure skips SDK/MCP). Across chains, failures are independent - a tools failure no longer skips superdoc and vice versa.
Must stay the same: SDK output contract (`sdk_python_snapshot_`, `sdk_release_`); CLI/SDK/MCP recovery paths.
Verified: `node --test scripts/tests/release-local.test.mjs` → 23 pass, 2 fail (the two failures are pre-existing on `main` and unrelated to this change).