chore: create measurement to layout ownership matrix#3158
chore: create measurement to layout ownership matrix#3158VladaHarbour wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
direction is right. three things inline.
Inline 1 - packages/layout-engine/docs/measuring-layout-ownership.md, line 1:
new docs/ folder - we keep layout-engine docs in CLAUDE.md and per-package READMEs today. could this go in CLAUDE.md instead? the follow-up list at the bottom feels like a Linear backlog.
Inline 2 - packages/layout-engine/layout-engine/src/measuring-layout-ownership-contracts.test.ts, lines 179-206:
the measuring test covers section breaks but this one only covers page and column breaks. could we add a section break case here too?
inline 3 - packages/layout-engine/layout-engine/src/measuring-layout-ownership-contracts.test.ts, lines 214-242:
this only passes because list layout isn't supported yet - when it lands, the test will start failing. could we use it.todo(...) so the next person updates it instead of deleting?
4 participants
This PR introduces measuring-layout-ownership.md document with Measuring → Layout ownership matrix and tests which lock current boundary.
@harbournick please let me know if it should live in the repo