perf(super-converter): replace xml-js with direct sax tree builder for DOCX import (SD-2291)#2514
Closed
caio-pizzol wants to merge 1 commit intomainfrom
Closed
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9caeb608c8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…r DOCX import Bypass xml-js's overhead (options validation, generic dispatch, JSON stringify+parse round-trip) by using sax.js directly with a purpose-built tree builder that produces the same non-compact JSON format. Benchmarks on customer's 11MB document.xml: - Old (JSON.parse(xml2json())): ~1,980ms (browser) - New (direct sax builder): ~810ms (browser) - ~2x faster across all document sizes The new parser produces identical output — verified by 13 unit tests including head-to-head comparison against xml-js on realistic DOCX fragments. SD-2291
caio-pizzol
force-pushed
the
caio/sd-2291-replace-xml-js-with-native-domparser-for-import
branch
from
9caeb60 to
b6f254a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bypass xml-js's overhead (options validation, generic dispatch, JSON stringify+parse round-trip) by using sax.js directly with a purpose-built tree builder that produces the same non-compact JSON format.
Benchmarks on customer's 11MB document.xml:
The new parser produces identical output — verified by 13 unit tests including head-to-head comparison against xml-js on realistic DOCX fragments.