refactor: header footer manager and footnotes builder

[harbournick]

No description provided.

[linear]

SD-1514 Layout engine infrastructure: PresentationEditor.ts

[chatgpt-codex-connector]

💡 Codex Review

superdoc/packages/super-editor/src/core/presentation-editor/header-footer/HeaderFooterSessionManager.ts

Lines 1117 to 1119 in 17bfd0b

	if (isFirstPageOfSection) {
	return 'first';
	}

Gate 'first' section type on titlePg being enabled

In #computeExpectedSectionType the refactor now returns 'first' for every first page in a section, regardless of whether the document/section has titlePg enabled. Previously (in PresentationEditor#computeExpectedSectionType) the first-page variant was only chosen when titlePg was true; otherwise the first page used 'default'. This means a document without title pages will label the first page’s header/footer region as 'first', so double-clicking an empty header/footer can create or open a “first” variant that is never rendered, making edits appear to disappear on normal pages.

---

superdoc/packages/super-editor/src/core/presentation-editor/header-footer/HeaderFooterSessionManager.ts

Lines 1129 to 1131 in 17bfd0b

	): HeaderFooterLayoutOptions['margins'] {
	const footnoteReserve = (page as Page & { footnoteReserve?: number }).footnoteReserve ?? 0;
	if (footnoteReserve <= 0) return margins;

Read footnoteReserved when stripping footer margins

The footer margin adjustment now reads page.footnoteReserve, but the layout engine populates Page.footnoteReserved (see contracts/layout-bridge). As a result, pages with footnotes won’t have their bottom margin reduced, so footer hit regions/decoration boxes can overlap the reserved footnote area. This is a regression from the previous implementation that used footnoteReserved.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".