Skip to content

Conversation

@harbournick
Copy link
Collaborator

@harbournick harbournick commented Jan 16, 2026

Refactor presentation editor input handling into dedicated managers

@harbournick harbournick self-assigned this Jan 16, 2026
@linear
Copy link

linear bot commented Jan 16, 2026

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

// Handle link clicks
const linkEl = target?.closest?.('a.superdoc-link') as HTMLAnchorElement | null;
if (linkEl) {
this.#handleLinkClick(event, linkEl);

P2 Badge Handle link activation on click/keyboard

Link interactions are now intercepted only from the pointerdown handler, and #handleLinkClick calls preventDefault() on that pointer event. That does not cancel the subsequent anchor activation (the default navigation happens on the click event), and keyboard activation (Enter/Space) won’t trigger pointerdown at all. The result is that clicking or keyboard-activating a .superdoc-link can navigate away instead of dispatching superdoc-link-click/goToAnchor. Consider handling click (or keydown on focused links) to reliably prevent navigation and emit the custom event.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@harbournick harbournick merged commit fd93831 into main Jan 16, 2026
4 checks passed
@harbournick harbournick deleted the nick/sd-1514-layout-engine-infrastructure-presentationeditorts branch January 16, 2026 22:29
@harbournick
Copy link
Collaborator Author

🎉 This PR is included in version 1.8.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants