make webpack5 compatible, fix the tags and resolve the import warning #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
import ejsPlugin from 'ejs-webpack-plugin') it gives a warning "Could not find a declaration file for module 'ejs-webpack-plugin'".How
compiler.plugin('emit', function (compilation, callback) { ... }method withcompiler.hooks.emit.tapAsync('EjsWebpackPlugin', function (compilation, callback) { ... }.path.posix.normalizeto convert the backward slashes to forward slashes. I replaced thenew RegExp(file).test(path.normalize(i))with/\.css/.test(path.normalize(i))to prevent it from adding "js" files in a link tag. Also, I added the "defer" to load the js after the document is parsed.declare module 'ejs-webpack-plugin';in index.d.ts to resolve the import warning.Screenshots
Request
Your plugin is just awesome. I had the issue with ejs combining with webpack for months and at last, your plugin has solved the issue. Please look into the PR and let me know if it's worth merging. And I would request you to update the npm distribution as it may help other developers. Thank you 😄.