Skip to content

Conversation

@Sreeja-99
Copy link

No description provided.

Added two implementations of the peak finding algorithm using binary search.
Implemented two methods to find the starting and ending position of a target in a sorted array: a linear search and a binary search approach.
Implemented two methods to find the minimum element in a rotated sorted array using binary search.
@super30admin
Copy link
Owner

  • Strengths:
    • The student demonstrates a good understanding of binary search and its variations.
    • The solutions are well-organized and mostly follow best practices.
    • The student provides multiple approaches (linear and binary search) for the same problem, showing flexibility in problem-solving.
  • Areas for Improvement:
    • The linear search approach in Leetcode_34.java (Way 1) should be avoided for this problem as it is less efficient.
    • The comments could be more concise and focused on explaining the logic rather than repeating the code.
    • Variable names could be more descriptive to improve readability.
    • The binary search logic in findFirst and findLast methods could be simplified further to match the reference solution's approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants