Skip to content

Completed Binary search 2#2283

Open
aditya-bandaru-06 wants to merge 1 commit intosuper30admin:masterfrom
aditya-bandaru-06:master
Open

Completed Binary search 2#2283
aditya-bandaru-06 wants to merge 1 commit intosuper30admin:masterfrom
aditya-bandaru-06:master

Conversation

@aditya-bandaru-06
Copy link
Copy Markdown

No description provided.

@super30admin
Copy link
Copy Markdown
Owner

  • Strengths: The student demonstrates a good understanding of binary search and its applications. The solutions for findMin and findPeakElement are concise and efficient. The code is readable and follows good practices.
  • Areas for Improvement:
    • For searchRange, consider using separate binary search functions for finding the first and last occurrences, as this approach is more straightforward and less prone to errors. The current implementation may not handle all edge cases correctly.
    • Add comments to explain the logic, especially for the searchRange function, to make it clearer why certain steps are taken.
    • Ensure that all edge cases are tested, such as when the target is not present or when it appears only once in the array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants