Skip to content

fix(pg_upgrade): use systemctl to start data.mount #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valigula wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −6
Open

fix(pg_upgrade): use systemctl to start data.mount #2144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ansible/files/admin_api_scripts/pg_upgrade_scripts/complete.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,12 +248,10 @@ function complete_pg_upgrade {
udevadm settle --timeout=60 || true
wait_for_data_device

retry 8 mount -a -v

# `nofail` in /etc/fstab makes `mount -a` exit with a code of 0 even when the volume is absent
# In the offchance of the volume not being mounted or detected, explicitly fail here
if ! mountpoint -q /data; then
echo "FATAL: /data is not a mountpoint"
# `mount -a` skips systemd-managed mounts (x-systemd.device-timeout in fstab)
systemctl start data.mount
if ! retry 8 mountpoint -q /data; then
echo "FATAL: /data is not a mountpoint after systemctl start data.mount"
exit 1
fi
else
Expand Down
Loading