feat: test pg_upgrade compatibility with older extension versions #1897
+545
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrose
approved these changes
Nov 6, 2025
samrose
requested changes
Nov 6, 2025
Collaborator
samrose
left a comment
samrose
left a comment
There was a problem hiding this comment.
Looks great! Will just need to test before we merge it
jfroche
force-pushed
the
feat/test-pg-upgrade-older-version
branch
from
8acfa60 to
f59c791
Compare
yvan-sraka
force-pushed
the
feat/test-pg-upgrade-older-version
branch
from
f59c791 to
779090b
Compare
yvan-sraka
force-pushed
the
feat/test-pg-upgrade-older-version
branch
2 times, most recently
from
24d66bb to
164f401
Compare
yvan-sraka
force-pushed
the
feat/test-pg-upgrade-older-version
branch
from
164f401 to
450b690
Compare
This comment has been minimized.
This comment has been minimized.
yvan-sraka
force-pushed
the
feat/test-pg-upgrade-older-version
branch
from
f6f9d9b to
9beb48a
Compare
yvan-sraka
force-pushed
the
feat/test-pg-upgrade-older-version
branch
from
9beb48a to
218357a
Compare
jfroche
force-pushed
the
custom-github-runners
branch
from
c1c4fd7 to
9b659e4
Compare
yvan-sraka
force-pushed
the
feat/test-pg-upgrade-older-version
branch
2 times, most recently
from
971248f to
84cfa8d
Compare
yvan-sraka
force-pushed
the
custom-github-runners
branch
from
efd8f49 to
a5fc472
Compare
yvan-sraka
force-pushed
the
feat/test-pg-upgrade-older-version
branch
2 times, most recently
from
39db71b to
29a4d56
Compare
yvan-sraka
force-pushed
the
custom-github-runners
branch
2 times, most recently
from
03dc754 to
c159bb6
Compare
jfroche
force-pushed
the
custom-github-runners
branch
3 times, most recently
from
df5545b to
b9294ee
Compare
jfroche
force-pushed
the
custom-github-runners
branch
24 times, most recently
from
182d513 to
1246b61
Compare
Add test to verify that all extension versions from PostgreSQL 15 can successfully upgrade to PostgreSQL 17 using pg_upgrade. The test now validates: - Each PG 15 extension version can be upgraded to PG 17 - Extension update scripts are properly generated during upgrade - Version handling works correctly with and without update scripts - Final extension versions match expected values after upgrade
…ade compatibility When upgrading PostgreSQL versions, pg_upgrade needs access to old extension versions sql to migrate from. This adds unsupported pg_graphql versions (those not compilable with current PostgreSQL) as SQL-only packages, ensuring migration paths exist when upgrading from older PostgreSQL versions.
…pgrade compatibility When upgrading PostgreSQL versions, pg_upgrade needs access to old extension versions sql to migrate from. This adds unsupported pg_graphql versions (those not compilable with current PostgreSQL) as SQL-only packages, ensuring migration paths exist when upgrading from older PostgreSQL versions.
When upgrading from PostgreSQL 15 to 17, pg_stat_monitor version 1.0 (PG 15-only) cannot be migrated as it uses .sql.in template files that reference MODULE_PATHNAME without proper processing for the target version. This marks version 1.0 as not pg_upgrade compatible and filters it from the version test list, allowing the test to use version 2.1 (which supports both PG 15 and 17) for pg_upgrade validation instead. Version 1.0 remains available for PG 15 installations. Version 2.1 has different schemas on PostgreSQL 15 vs 17 despite sharing the same version number. On PG 15 it uses the older schema with blk_read_time and blk_write_time columns, while on PG 17 it uses a newer schema with shared_blk_read_time, shared_blk_write_time, local_blk_read_time, local_blk_write_time and additional JIT statistics columns. During pg_upgrade from PG 15 to 17, the extension version remains 2.1 without schema migration since no update script is generated. Fresh installations on PG 17 receive the new schema while pg_upgrade retains the old schema, creating a test conflict as both scenarios share the same expected output file. A custom test implementation skips pg_regress validation after pg_upgrade when no update script is generated, since the schema mismatch is expected behavior. This maintains full test coverage for fresh installations through the regular psql_17 check while validating extension version compatibility for pg_upgrade scenarios.
yvan-sraka
force-pushed
the
feat/test-pg-upgrade-older-version
branch
from
29a4d56 to
d36e133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to verify that all extension versions from PostgreSQL 15 can successfully upgrade to PostgreSQL 17 using pg_upgrade.
The test now validates: