Skip to content

fix: remove dots from allowed project_id characters to prevent Vector container crashes #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7ttp wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: remove dots from allowed project_id characters to prevent Vector container crashes #4768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ var (
initConfigEmbed string
initConfigTemplate = template.Must(template.New("initConfig").Parse(initConfigEmbed))

invalidProjectId = regexp.MustCompile("[^a-zA-Z0-9_.-]+")
invalidProjectId = regexp.MustCompile("[^a-zA-Z0-9_-]+")
refPattern = regexp.MustCompile(`^[a-z]{20}$`)
)

Expand Down Expand Up @@ -975,10 +975,10 @@ func truncateText(text string, maxLen int) string {
const maxProjectIdLength = 40

func sanitizeProjectId(src string) string {
// A valid project ID must only contain alphanumeric and special characters _.-
// A valid project ID must only contain alphanumeric and special characters _-
sanitized := invalidProjectId.ReplaceAllString(src, "_")
// It must also start with an alphanumeric character
sanitized = strings.TrimLeft(sanitized, "_.-")
sanitized = strings.TrimLeft(sanitized, "_-")
// Truncate sanitized ID to 40 characters since docker hostnames cannot exceed
// 63 characters, and we need to save space for padding supabase_*_edge_runtime.
return truncateText(sanitized, maxProjectIdLength)
Expand Down
Loading