draft: fix many completion issues from snapshots

crates/pgls_completions/src/builder.rs

@@ -2,6 +2,7 @@ use crate::{
     CompletionItemKind, CompletionText,
     item::CompletionItem,
     relevance::{filtering::CompletionFilter, scoring::CompletionScore},
+    sanitization,
 };
 
 use pgls_treesitter::TreesitterContext;
@@ -24,6 +25,12 @@ pub(crate) struct CompletionBuilder<'a> {
 
 impl<'a> CompletionBuilder<'a> {
     pub fn new(ctx: &'a TreesitterContext) -> Self {
+        println!(
+            "is sanitized: {:#?}",
+            ctx.get_node_under_cursor_content()
+                .map(|txt| sanitization::is_sanitized_token(txt.as_str()))
+        );
+
         CompletionBuilder { items: vec![], ctx }
     }
 
@@ -42,6 +49,11 @@ impl<'a> CompletionBuilder<'a> {
             item.score.calc_score(self.ctx);
         }
 
+        items = items
+            .into_iter()
+            .filter(|i| !i.score.should_skip())
+            .collect();
+
         items.sort_by(|a, b| {
             b.score
                 .get_score()

crates/pgls_completions/src/providers/columns.rs

@@ -50,9 +50,10 @@ fn get_completion_text(ctx: &TreesitterContext, col: &Column) -> CompletionText
 
 #[cfg(test)]
 mod tests {
+    use pgls_test_utils::QueryWithCursorPosition;
     use sqlx::PgPool;
 
-    use crate::test_helper::{TestCompletionsCase, TestCompletionsSuite};
+    use crate::test_helper::{TestCompletionsCase, TestCompletionsSuite, assert_complete_results};
 
     #[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
     async fn handles_nested_queries(pool: PgPool) {
@@ -79,12 +80,12 @@ mod tests {
         TestCompletionsCase::new()
         .inside_static_statement(r#"
             select * from (
-                <sql>
+                <sql> from private.audio_books
             ) as subquery
             join public.users u
             on u.id = subquery.id;
             "#)
-            .type_sql("select id, narrator_id<1> from private.audio_books")
+            .type_sql("select id, narrator_id<1>")
             .comment("Should prefer the one from private.audio_audiobooks, since the other tables are out of scope.")
         )
             .snapshot("handles_nested_queries")
@@ -459,9 +460,6 @@ mod tests {
         "#;
 
         TestCompletionsSuite::new(&pool, Some(setup))
-            .with_case(
-                TestCompletionsCase::new().type_sql("alter table instruments drop column name"),
-            )
             .with_case(
                 TestCompletionsCase::new().type_sql("alter table instruments drop column name"),
             )

crates/pgls_completions/src/relevance/filtering.rs

@@ -1,6 +1,8 @@
 use pgls_schema_cache::ProcKind;
 use pgls_treesitter::context::{TreesitterContext, WrappingClause, WrappingNode};
 
+use crate::is_sanitized_token;
+
 use super::CompletionRelevanceData;
 
 #[derive(Debug)]
@@ -43,6 +45,10 @@ impl CompletionFilter<'_> {
             return None;
         }
 
+        if ctx.before_cursor_matches_kind(&["ERROR"]) {
+            return None;
+        }
+
         // "literal" nodes can be identfiers wrapped in quotes:
         // `select "email" from auth.users;`
         // Here, "email" is a literal node.