New Feature: Search data-filterTableKeywords as well as text #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added matching of data attribute for extra filtering.
Based on simple example with quick tags
Contributor
Author
|
@sunnywalker Is there some changes I should make to this pull request for it to be merged? |
Contributor
Author
|
@sunnywalker I have been using this change quite well on my own systems, is this something you are willing to merge in do you think? |
Added back in isMatch function that had gone missing from repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the requirement to filter based on extra text so I implemented code where the data-filterTableKeywords attribute on any tags is also checked for search string.
Obviously i have only updated jquery.filtertable.js and not jquery.filtertable.min.js
I also wondered about adding a new config option to allow user to specify name of data attribute. Can look to do that if this pull request is accepted.
This is different to pullrequest #17 as it adds extra keywords to be searched on also rather than searching on a differnt value.