Reduced the drop-shadow on 'single-hadith-view' navigation buttons#54
Open
Tawfiqh wants to merge 1 commit intosunnah-com:masterfrom
Open
Reduced the drop-shadow on 'single-hadith-view' navigation buttons#54Tawfiqh wants to merge 1 commit intosunnah-com:masterfrom
Tawfiqh wants to merge 1 commit intosunnah-com:masterfrom
Conversation
Reduced the drop-shadow on 'single-hadith-view' navigation buttons Now consistent with the 'actualHadithContainer' css class and the overall flat-design of the page.
Contributor
|
Salaam @fsid - Thoughts? Also can you please take a look and see if any additions need to be made for the other screen sizes? |
Collaborator
|
Wa Alaikumussalaam, JazakAllah for the PR @Tawfiqh The idea behind a prominent shadow was to add depth perception. We wanted the buttons showing more height because they needed to stand out, but not catch too much attention. also to differentiate better from the background. I see the idea behind creating consistency and agree. Perhaps there is a happy compromise in the middle? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced the drop-shadow on 'single-hadith-view' navigation buttons
Now consistent with the 'actualHadithContainer' css class and the overall flat-design of the page.