deprecate(UIPanel): mark as deprecated in favour of GuiPanel#99
Closed
AmlanDalai wants to merge 1 commit intosumit3203:masterfrom
Closed
deprecate(UIPanel): mark as deprecated in favour of GuiPanel#99AmlanDalai wants to merge 1 commit intosumit3203:masterfrom
AmlanDalai wants to merge 1 commit intosumit3203:masterfrom
Conversation
- UIPanel and GuiPanel duplicate the same navigation functionality - Add @deprecated annotation and @deprecated Javadoc on class and methods - Migrate layout from setLayout(null) to GridBagLayout for consistency - Remove System.out.println debug statements from constructor - Add Javadoc referencing GuiPanel as the canonical replacement
Contributor
Author
Note on diff sizeThis PR makes the following distinct changes:
The large diff is due to layout restructuring. All button actions and functionality are identical to the original. |
Contributor
Author
|
Closing this PR following mentor feedback. UIPanel is the newer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The codebase contains two navigation panels -
UIPanelandGuiPanel- that serve identical purposes. This duplication increases maintenance burden and creates ambiguity about which class should be used for future development.Problem
UIPanelandGuiPanelboth:Maintaining two parallel implementations increases the risk of divergence and makes future UI improvements harder to apply consistently.
Changes
@Deprecatedannotation and@deprecatedJavadoc tag to class and methodsGuiPanelas the canonical replacement in all deprecation noticessetLayout(null)toGridBagLayoutfor consistency withGuiPanelSystem.out.printlndebug statements from constructorNote
UIPanelis retained for backwards compatibility. No functionality has been removed. The deprecation signals intent to consolidate intoGuiPanelin a future release.