fix: call setVisible(true) on SessionGUI instance to display the panel#95
Open
AmlanDalai wants to merge 3 commits intosumit3203:masterfrom
Open
fix: call setVisible(true) on SessionGUI instance to display the panel#95AmlanDalai wants to merge 3 commits intosumit3203:masterfrom
AmlanDalai wants to merge 3 commits intosumit3203:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Problem
In GuiPanel.java, when the "View Sessions" button was clicked,
a new SessionGUI instance was created but never made visible:
Fix
Store the instance and call setVisible(true) so the panel
actually appears when the button is clicked:
Impact
Users clicking "View Sessions" button would see nothing happen.
This fix makes the Sessions panel actually appear as expected.