Fix: refactor ConvGpu for improved GPU convolution#121
Open
Pakhi-7831 wants to merge 2 commits intosumit3203:masterfrom
Open
Fix: refactor ConvGpu for improved GPU convolution#121Pakhi-7831 wants to merge 2 commits intosumit3203:masterfrom
Pakhi-7831 wants to merge 2 commits intosumit3203:masterfrom
Conversation
Refactor ConvGpu class to improve GPU convolution methods, including convolve2DGpu and updates to convolveFloat1D. Added error handling and memory management enhancements.
Pakhi-7831
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves and fixes the GPU separable convolution path used by the ImageJ active segmentation filters.
Changes
Significance
The platform relies heavily on separable Gaussian/derivative-style filters. The previous GPU approach suffered from high per-line overhead and could route separable computations incorrectly, leading to both performance loss and potential output inconsistencies. These changes improve correctness of separable routing and increase throughput of GPU filtering.