fix(CreateOpenProjectGUI): fix broken file chooser directory memory and remove dead code#110
Closed
AmlanDalai wants to merge 4 commits intosumit3203:masterfrom
Closed
Conversation
- Replace reference equality (==) with .equals() for ActionEvent dispatch in doAction() — same class of bug fixed in GuiPanel (PR sumit3203#6) - Remove System.out.println debug statements from doAction() and updateClassifier() - Add full Javadoc to all methods and class
…out and Image Stack truncation
…nd remove dead code
Contributor
Author
|
Superseded by #111 — recreated from clean upstream master to avoid unrelated file changes. |
AmlanDalai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Removed dead code (line 70)
setDefaultCloseOperation(EXIT_ON_CLOSE)was immediately overwrittenby
setDefaultCloseOperation(DO_NOTHING_ON_CLOSE)on the next line.Removed the dead first call.
2. Fixed file chooser "remember directory" bug (lines 133-137)
The
currentDircheck was placed AFTERshowOpenDialog(), meaningthe dialog had already closed by the time we tried to set the directory.
Before: File chooser always opened at default directory
After: File chooser remembers and opens at the last-used directory
Fix details
currentDircheck BEFOREshowOpenDialog()setSelectedFile()tosetCurrentDirectory(currentDir.getParentFile())for proper directory navigation
Testing