Draft
Conversation
i think some docstrings, about a counter, were outdated. i add more details to help understand the logic. Signed-off-by: charles <charles.englebert@protonmail.com>
crash-save mode consist in indexing documents in ascending updated_at order and save the last document.update_at. This allows resuming indexing from the last successful batch in case of a crash. Signed-off-by: charles <charles.englebert@protonmail.com>
mascarpon3
force-pushed
the
improve-indexing-command
branch
3 times, most recently
from
d374d7c to
a3acb66
Compare
we need to be able to specify time bounds on the bulk index to allow recovering from checkpoint after crash Signed-off-by: charles <charles.englebert@protonmail.com>
mascarpon3
force-pushed
the
improve-indexing-command
branch
from
a3acb66 to
6d91fca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
to index all documents we need to be able to restart from last successful batch in case of crash. to do so we need to be able to specify time bounds on the bulk index to allow recovering from checkpoint after crash and asynchronously delegate it to celery worker.
Proposal
lower_time_boundandupper_time_boundargsExternal contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)