♿️(frontend) structure correctly 5xx error alerts #2128
Open
Conversation
Ovgodd
changed the title
Ovgodd
force-pushed
the
fix/error-page-translation
branch
from
1cda75b to
ccf023c
Compare
Use h1/p for 500/502/503; pass status from doc and version views.
Ovgodd
force-pushed
the
fix/error-page-translation
branch
from
ccf023c to
d8d655c
Compare
|
Size Change: +317 B (+0.01%) Total Size: 4.24 MB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the server error alert component (
TextErrors) so that HTTP 5xx errors are displayed with a structured heading (<h2>) and a paragraph (<p>) instead of raw<span>elements. This makes the error accessible to screen readers (heading navigation) and prepares the keys for future i18n translation.Proposal
statusprop toTextErrors/TextOnlyErrorsuseHttpErrorMessageshook witht()literals for 500/502/503<h1>+<p>with normalized font size when a known status is passed