♿(frontend) use aria-haspopup menu on DropButton triggers#2126
Open
♿(frontend) use aria-haspopup menu on DropButton triggers#2126
Conversation
Replace aria-haspopup true with menu on DropButton
32e83cc to
2b60f68
Compare
|
Size Change: +9 B (0%) Total Size: 4.24 MB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix incorrect VoiceOver announcements on menu triggers that use
DropButton(document actions, language selector, and other dropdowns). The deprecated booleanaria-haspopup="true"led VoiceOver to read “rejected” instead of the expanded/collapsed menu stateProposal
aria-haspopup="menu"on theDropButtontrigger (matches therole="menu"content).DropdownMenuunit test expectations foraria-haspopup.