Skip to content

♿(frontend) use aria-haspopup menu on DropButton triggers#2126

Open
Ovgodd wants to merge 1 commit intomainfrom
fix/voice-over-rejected
Open

♿(frontend) use aria-haspopup menu on DropButton triggers#2126
Ovgodd wants to merge 1 commit intomainfrom
fix/voice-over-rejected

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Mar 25, 2026

Purpose

Fix incorrect VoiceOver announcements on menu triggers that use DropButton (document actions, language selector, and other dropdowns). The deprecated boolean aria-haspopup="true" led VoiceOver to read “rejected” instead of the expanded/collapsed menu state

Proposal

  • Set aria-haspopup="menu" on the DropButton trigger (matches the role="menu" content).
  • Update DropdownMenu unit test expectations for aria-haspopup.

@Ovgodd Ovgodd requested a review from AntoLC March 25, 2026 09:15
@Ovgodd Ovgodd self-assigned this Mar 25, 2026
Replace aria-haspopup true with menu on DropButton
@Ovgodd Ovgodd force-pushed the fix/voice-over-rejected branch from 32e83cc to 2b60f68 Compare March 25, 2026 09:15
@Ovgodd Ovgodd marked this pull request as ready for review March 25, 2026 09:15
@Ovgodd Ovgodd linked an issue Mar 25, 2026 that may be closed by this pull request
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Mar 25, 2026
@github-actions
Copy link

github-actions bot commented Mar 25, 2026

Size Change: +9 B (0%)

Total Size: 4.24 MB

Filename Size Change
apps/impress/out/_next/static/9a6cafb9/_buildManifest.js 0 B -622 B (removed) 🏆
apps/impress/out/_next/static/380a8f1a/_buildManifest.js 622 B +622 B (new file) 🆕

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Document action buttons: "rejected" state rendered incorrectly

1 participant