Skip to content

🐛(backend) do not filter deleted docs for the owner in the tree view#2121

Open
Ash-Crow wants to merge 1 commit intomainfrom
sbl-fix-delete-document-request-conflict
Open

🐛(backend) do not filter deleted docs for the owner in the tree view#2121
Ash-Crow wants to merge 1 commit intomainfrom
sbl-fix-delete-document-request-conflict

Conversation

@Ash-Crow
Copy link
Collaborator

Purpose

Fixes the bug described in #1254 (Delete document request conflict)

In the tree request, deleted documents for
which the user is the owner are not filtered anymore.

Proposal

  • If the user is logged in, their deleted documents are now included in the query for children.
  • Update unit tests

@Ash-Crow Ash-Crow force-pushed the sbl-fix-delete-document-request-conflict branch 2 times, most recently from 428e3fa to 8929ac3 Compare March 24, 2026 14:49
Fixes the bug described in #1254 (Delete document request conflict)

In the tree request, deleted documents for
which the user is the owner are not filtered anymore.
@Ash-Crow Ash-Crow force-pushed the sbl-fix-delete-document-request-conflict branch from 8929ac3 to d786e97 Compare March 24, 2026 16:02
@Ash-Crow Ash-Crow requested review from AntoLC and lunika March 24, 2026 16:03
@Ash-Crow Ash-Crow changed the title 🐛(backend) do not filter deleted documents for the owner in the tree view 🐛(backend) do not filter deleted docs for the owner in the tree view Mar 24, 2026
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't succeed to reproduce the bug, did you get it ?

@virgile-dev
Copy link
Collaborator

Hey @Ash-Crow
Like @AntoLC said, apparently the bug was solved when we released the trash feature.
Sorry I gave this you. If you can try to reproduce before you make a PR that'd be much appreciated.
Finally, I discussed the behaviour you implemented with @lunika. It's not the desired one.
We do not wish to display deleted child for owners.
Let's discuss it thursday to see if we close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants