Skip to content

🐛(frontend) preserve typed text after @ on escape #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ovgodd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛(frontend) preserve typed text after @ on escape #1833

Ovgodd wants to merge 1 commit into from
+3 −2

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Jan 27, 2026 •
edited
Loading

Purpose

Fix the interlinking search behavior so pressing Escape keeps the @ (or /) plus the text the user already typed.

preservetext.mp4

Proposal

  • Preserve typed input when closing the inline search with Escape
  • Keep existing Backspace/selection behaviors unchanged

@Ovgodd Ovgodd requested a review from AntoLC January 27, 2026 14:14
@Ovgodd Ovgodd self-assigned this Jan 27, 2026
@Ovgodd Ovgodd added bug Something isn't working frontend labels Jan 27, 2026
@Ovgodd
🐛(frontend) preserve typed text after @ on escape
781f081 
prevents losing input when closing interlink search
@Ovgodd Ovgodd linked an issue Jan 27, 2026 that may be closed by this pull request
Escape on @ doesn't work properly when content is typed #1699
Open
@Ovgodd Ovgodd marked this pull request as ready for review January 27, 2026 14:15
@github-actions
Copy link

github-actions bot commented Jan 27, 2026 •
edited
Loading

Size Change: +6 B (0%)

Total Size: 4.19 MB

Filename Size Change
apps/impress/out/_next/static/448fb98e/_buildManifest.js 852 B +852 B (new file) 🆕
apps/impress/out/_next/static/ba531a67/_buildManifest.js 0 B -851 B (removed) 🏆

compressed-size-action

AntoLC
AntoLC approved these changes Jan 27, 2026
View reviewed changes
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoLC AntoLC AntoLC approved these changes

Assignees

@Ovgodd Ovgodd

Labels

bug Something isn't working frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Escape on @ doesn't work properly when content is typed

3 participants

@Ovgodd @AntoLC