🐛(backend) properly encode attachment upload content-disposition header #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the Content-Disposition header set on S3 PutObject requests when uploading attachments to be encoded using a Django helper, properly encoding UTF-8 in filenames. This fixes compatibility for uploading attachments with non ASCII file names to Garage, since the HTTP library used by Garage validates that HTTP Headers are ASCII only. Signed-off-by: networkException <git@nwex.de>
networkException
force-pushed
the
putobject-content-disposition-encoding
branch
from
81d84c0 to
6979757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request changes the Content-Disposition header set on S3 PutObject requests when uploading attachments to be encoded using a Django helper, properly encoding UTF-8 in filenames.
This fixes compatibility for uploading attachments with non ASCII file names to Garage, since the HTTP library used by Garage validates that HTTP Headers are ASCII only.
Proposal
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)