🚸(frontend) remove blocking modal on save in Firefox #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
added
bug
In firefox the request to save documents did not complete when the user where closing is tab or browser. To let the save request complete we added a blocking modal, but it was not user friendly. Now we removed the blocking modal and add "keepalive" option to the fetch request to let the request complete in background when the user close the tab or browser.
AntoLC
force-pushed
the
fix/modal-save-firefox
branch
from
1b57e30 to
12d1721
Compare
|
Size Change: +55 B (0%) Total Size: 4.17 MB
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In Firefox the request to save documents did not complete when the user where closing is tab or browser. To let the save request complete we added a blocking modal, but it was not user friendly.
Now we removed the blocking modal and add "keepalive" option to the fetch request to let the request complete in background when the user close the tab or browser.