Skip to content

Conversation

@StephanMeijer
Copy link
Collaborator

@StephanMeijer StephanMeijer commented Nov 15, 2025

Purpose

We can now import docx and and md files just by dropping them into the docs grid area.
To do so we added a new container "docspec", which uses the docspec service to convert these formats to Blocknote format.

Import of (markdown) documents. See #1567 #1569.

Demo

Docs.1.online-video-cutter.com.mp4

@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Size Change: +19.4 kB (+0.47%)

Total Size: 4.18 MB

Filename Size Change
apps/impress/out/_next/static/4782ca0f/_buildManifest.js 0 B -889 B (removed) 🏆
apps/impress/out/_next/static/b76b81b4/_buildManifest.js 886 B +886 B (new file) 🆕
apps/impress/out/_next/static/chunks/399.js 779 kB +779 kB (new file) 🆕
apps/impress/out/_next/static/chunks/8343.js 0 B -761 kB (removed) 🏆
apps/impress/out/_next/static/chunks/8495.js 64.9 kB +1.8 kB (+2.85%)

compressed-size-action

@github-actions
Copy link

🚀 Preview will be available at https://1609-docs.ppr-docs.beta.numerique.gouv.fr/

You can use the existing account with these credentials:

  • username: docs
  • password: docs

You can also create a new account if you want to.

Once this Pull Request is merged, the preview will be destroyed.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@StephanMeijer StephanMeijer force-pushed the feature/doc-import branch 2 times, most recently from a9c28e9 to 9cef0a0 Compare January 8, 2026 11:01
StephanMeijer added a commit that referenced this pull request Jan 8, 2026
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
StephanMeijer added a commit that referenced this pull request Jan 8, 2026
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
@StephanMeijer StephanMeijer force-pushed the feature/doc-import branch 3 times, most recently from b7ca2f2 to d973836 Compare January 8, 2026 15:53
@socket-security
Copy link

socket-security bot commented Jan 8, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​html-to/​text-cli@​0.5.4781009976100
Addedmjml@​4.18.099999793100

View full report

@AntoLC AntoLC force-pushed the feature/doc-import branch from 5e4acab to bdffa76 Compare January 9, 2026 09:17
StephanMeijer and others added 4 commits January 9, 2026 10:18
We can now import documents in formats .docx and .md.
To do so we added a new container "docspec", which
uses the docspec service to convert
these formats to Blocknote format.

More here: #1567 #1569.
Adapt the docs grid title bar to align with the
new design. We will add a upload button in a
future iteration.
Add import document area with drag and drop
support in the docs grid component.
We can now import docx and and md files just
by dropping them into the designated area.

We are using the `react-dropzone` library to
handle the drag and drop functionality.
Updated docspec service image from 2.0.0 to 2.4.4 to
include latest features and bug fixes.

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
@AntoLC AntoLC force-pushed the feature/doc-import branch from bdffa76 to df60fc6 Compare January 9, 2026 09:20
@socket-security
Copy link

socket-security bot commented Jan 9, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm js-beautify is 100.0% likely obfuscated

Confidence: 1.00

Location: Package overview

From: ?npm/mjml@4.18.0npm/js-beautify@1.15.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/js-beautify@1.15.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Added comprehensive tests covering DocSpec converter service,
converter orchestration, and document creation with file uploads.

Tests validate DOCX and Markdown conversion workflows, error
handling, service availability, and edge cases including empty
files and Unicode filenames.

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
@AntoLC AntoLC force-pushed the feature/doc-import branch from df60fc6 to e71eb79 Compare January 9, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(DocSpec) Infrastuctural integration with La Suite (Docker Compose, Helm) (DocSpec) Integration between DocSpec and La Suite Docs

4 participants