Skip to content

ret needs to be false if set_user_groups fails #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
millert merged 1 commit into from
Dec 18, 2025
Merged

ret needs to be false if set_user_groups fails #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/sudo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,9 +1411,11 @@ policy_init_session(struct command_details *details)
* groups to be set via pam_group(8) in pam_setcred(3).
*/
if (ISSET(details->flags, CD_SET_GROUPS)) {
/* set_user_groups() prints error message on failure. */
if (!set_user_groups(details))
goto done;
/* set_user_groups() prints error message on failure. */
if (!set_user_groups(details)) {
ret = false;
goto done;
}
}

/* Session setup may override sudoers umask so set it first. */
Expand Down
Loading