-
Notifications
You must be signed in to change notification settings - Fork 17
chore: use pixi for codegen environment in ci #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've never heard of |
|
it's just a faster alternative to conda, written in rust of course 😆 you can't configure system dependencies with uv (antlr, buf and protoc in this case). this PR only changes codegen check to use pixi which used whole devcontainer before. tests are still run with only uv. Although maybe it might make sense to port everything to pixi in the future as well for simplicity, not sure. |
|
Can you update the CONTRIBUTING.md? |
|
done, also upgraded libprotobuf to latest in pixi as well |
Co-authored-by: Niels Pardon <mail@niels-pardon.de>
| lint = "ruff check" | ||
| lint_fix = "ruff check --fix" | ||
|
|
||
| update-submodule = "./update_submodule.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels to me for the time being (until substrait-io/substrait#925) one would always run codegen after updating the submodule. what do you think about linking them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aka update-submodule triggers codegen but you can still do codegen independently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turns out you can't link them like this update-submodule = [ "./update_submodule.sh", { task = "codegen" }], so I added another update-substrait task that runs both instead.
nielspardon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, much nicer approach with pixi
No description provided.