fix(isthmus): assertFullRoundTrip for any_value#783
Merged
bestbeforetoday merged 3 commits intosubstrait-io:mainfrom Mar 27, 2026
Merged
fix(isthmus): assertFullRoundTrip for any_value#783bestbeforetoday merged 3 commits intosubstrait-io:mainfrom
bestbeforetoday merged 3 commits intosubstrait-io:mainfrom
Conversation
Use Calcite's SqlBasicAggFunction instead of defining a custom subclass of SqlFunction to represent aggregate functions. Some refactor of toSqlFunction into smaller collaborating functions to make the logical flow and intent clearer. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Member
bestbeforetoday
left a comment
bestbeforetoday
left a comment
There was a problem hiding this comment.
I really like the way you have broken out the return type inference into distinct classes with the logic implemented in small focused methods. The testing is also nice and clear.
One suggestion is to use Calcite's SqlBasicAggFunction instead of defining a custom subclass of SqlAggFunction (with no behavioural changes) to represent aggregate functions. I have raised a pull request against your PR branch with my suggested change.
refactor: use SqlBasicAggFunction in toSqlFunction
bestbeforetoday
approved these changes
Mar 27, 2026
Member
bestbeforetoday
left a comment
bestbeforetoday
left a comment
There was a problem hiding this comment.
Great contribution. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #781
The existing AutomaticDynamicFunctionMappingConverterProvider could not handle Substrait functions with parameterized return types (e.g., any1?). Functions like any_value, lag, and first_value failed because the return type inference couldn't resolve parameterized types to concrete Calcite types.
This PR fixes automatic mapping of standard substrait aggregate functions to SqlOperator's and implements a type inference system with separate logic for scalar, aggregate, and window functions, each with appropriate fallback behavior and nullability handling.