docs(core): add javadoc, excluding Expression#778
Merged
andrew-coleman merged 1 commit intosubstrait-io:mainfrom Mar 26, 2026
Merged
docs(core): add javadoc, excluding Expression#778andrew-coleman merged 1 commit intosubstrait-io:mainfrom
andrew-coleman merged 1 commit intosubstrait-io:mainfrom
Conversation
This change adds missing Javadoc to address build warnings in all classes except for io.substrait.expression.Expression. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
mbwhite
approved these changes
Mar 26, 2026
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| /** Abstract base class for binary relations that have exactly two input relations. */ |
Contributor
There was a problem hiding this comment.
can you have a binary relation without two inputs :-)
| return visitor.visit(this, context); | ||
| } | ||
|
|
||
| /** Represents a grouping set - a set of expressions to group by. */ |
Member
There was a problem hiding this comment.
... by which to group :)
andrew-coleman
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds missing Javadoc to address build warnings in all classes except for io.substrait.expression.Expression.