docs(isthmus): javadoc for ContentProvider & subclasses#777
Merged
bestbeforetoday merged 1 commit intosubstrait-io:mainfrom Mar 27, 2026
Merged
docs(isthmus): javadoc for ContentProvider & subclasses#777bestbeforetoday merged 1 commit intosubstrait-io:mainfrom
bestbeforetoday merged 1 commit intosubstrait-io:mainfrom
Conversation
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
mbwhite
force-pushed
the
javadoc-converterprovider
branch
from
6fdcf51 to
db3c67a
Compare
mbwhite
changed the title
mbwhite
force-pushed
the
javadoc-converterprovider
branch
2 times, most recently
from
6e8ce0d to
188709e
Compare
bestbeforetoday
requested changes
Mar 26, 2026
Member
bestbeforetoday
left a comment
bestbeforetoday
left a comment
There was a problem hiding this comment.
All good other than one comment on the DynamicConvererProvider class documentation. See inline comment. I think this is worth changing to clarify the distinction between DynamicConverterProvider and AutomaticDynamicFunctionMappingConverterProvider.
isthmus/src/main/java/io/substrait/isthmus/DynamicConverterProvider.java
Show resolved
Hide resolved
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
javadoc-converterprovider
branch
from
188709e to
5f1768e
Compare
bestbeforetoday
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContentProvider JavaDoc