chore: remove unused TypeExpressionProtoVisitor #675
+0
−432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
Member
|
I'm in support of this, but let's wait until the upstream is resolved before merging this IMO. EDIT: Also, when the upstream settles, we will have to bump the version of substait here, and then this file will become a compilation error :) |
Member
Author
Fine with me. Just found this file in my research to understand whether this is used anywhere and thought I prepare the PR before I forget about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to substrait-io/substrait#940 and substrait-io/substrait#849
This class is for an unused part of the Substrait specification and is not used anywhere.