Skip to content

build(core): fix Spotless failure following PR merge #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bestbeforetoday merged 1 commit into from
Jan 15, 2026
Merged

build(core): fix Spotless failure following PR merge #674

bestbeforetoday merged 1 commit into from
Jan 15, 2026

Conversation

@bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented Jan 14, 2026

Commits 13309df and 5e2d0bb combined to produce a Spotless check failure. This change fixes the formatting and adds a missing Javadoc comment.

@bestbeforetoday bestbeforetoday marked this pull request as ready for review January 14, 2026 12:10
@bestbeforetoday
build(core): fix Spotless failure following PR merge
27a86d0 
Commits 13309df and 5e2d0bb combined to produce a Spotless check
failure. This change fixes the formatting and adds a missing Javadoc
comment.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
@nielspardon
Copy link
Member

nielspardon commented Jan 15, 2026 •
edited
Loading

Looks like this no longer fixes a formatting issue but just adds a comment. Can you update the commit and PR title?

@bestbeforetoday
Copy link
Member Author

bestbeforetoday commented Jan 15, 2026

@nielspardon The blank line this PR adds fixes a Spotless check failure. I can remove the comment if you prefer.

@nielspardon
Copy link
Member

nielspardon commented Jan 15, 2026

@nielspardon The blank line this PR adds fixes a Spotless check failure. I can remove the comment if you prefer.

Thanks, that wasn't obvious to me.

nielspardon
nielspardon approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@nielspardon nielspardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bestbeforetoday bestbeforetoday merged commit 931bdd6 into substrait-io:main Jan 15, 2026
12 checks passed
@bestbeforetoday bestbeforetoday deleted the spotless-fix branch January 15, 2026 15:37
mbwhite pushed a commit to mbwhite/substrait-java that referenced this pull request Jan 16, 2026
@bestbeforetoday @mbwhite
build(core): fix Spotless failure following PR merge (substrait-io#674)
abafe1d 
Commits 13309df and 5e2d0bb combined to produce a Spotless check
failure. This change fixes the formatting and adds a missing Javadoc
comment.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielspardon nielspardon nielspardon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bestbeforetoday @nielspardon