fix: javadoc for the isthmus library #645

mbwhite · 2025-12-17T16:14:25Z

No description provided.

isthmus/src/main/java/io/substrait/isthmus/OuterReferenceResolver.java

isthmus/src/main/java/io/substrait/isthmus/PreCalciteAggregateValidator.java

isthmus/src/main/java/io/substrait/isthmus/RelNodeVisitor.java

isthmus/src/main/java/io/substrait/isthmus/SqlToSubstrait.java

isthmus/src/main/java/io/substrait/isthmus/SubstraitRelNodeConverter.java

isthmus/src/main/java/io/substrait/isthmus/SubstraitRelVisitor.java

isthmus/src/main/java/io/substrait/isthmus/TypeConverter.java

isthmus/src/main/java/io/substrait/isthmus/calcite/SubstraitOperatorTable.java

isthmus/src/main/java/io/substrait/isthmus/calcite/SubstraitTable.java

isthmus/src/main/java/io/substrait/isthmus/calcite/rel/DdlSqlToRelConverter.java

isthmus/src/main/java/io/substrait/isthmus/expression/AggregateFunctionConverter.java

isthmus/src/main/java/io/substrait/isthmus/expression/FunctionConverter.java

nielspardon · 2026-01-13T13:35:56Z

isthmus/src/main/java/io/substrait/isthmus/expression/FunctionConverter.java

+    /**
+     * Creates a function finder for a Substrait name/operator over given variants.
+     *
+     * @param substraitName canonical Substrait function name


this makes me wonder whether we should have an example here to help disambiguate between the function signature concat:str_str and the function name concat

isthmus/src/main/java/io/substrait/isthmus/expression/FunctionMappings.java

nielspardon · 2026-01-15T12:46:38Z

isthmus/src/main/java/io/substrait/isthmus/expression/ListSqlOperatorFunctions.java

 import org.apache.calcite.sql.fun.SqlMultisetSetOperator;
 import org.apache.calcite.sql.fun.SqlStdOperatorTable;

+/**


If you rebase then this file has been removed.

isthmus/src/main/java/io/substrait/isthmus/sql/SubstraitSqlDialect.java

isthmus/src/main/java/io/substrait/isthmus/expression/IgnoreNullableAndParameters.java

Signed-off-by: MBWhite <whitemat@uk.ibm.com>

substrait

Signed-off-by: MBWhite <whitemat@uk.ibm.com>

nielspardon · 2026-01-16T13:12:23Z

isthmus/src/main/java/io/substrait/isthmus/expression/ListSqlOperatorFunctions.java

I had deleted this file in #672

I guess you would also delete it from your branch so you're not bringing it back.

nielspardon · 2026-01-16T13:13:01Z

isthmus/src/main/java/io/substrait/isthmus/expression/FunctionMappings.java

+  /**
+   * Prints all scalar signatures (for quick inspection).
+   *
+   * @param args CLI arguments (unused)
+   */
+  public static void main(String[] args) {
+    SCALAR_SIGS.forEach(System.out::println);
+  }
+


I deleted this one in: #672

Suggested change

/**

* Prints all scalar signatures (for quick inspection).

*

* @param args CLI arguments (unused)

*/

public static void main(String[] args) {

SCALAR_SIGS.forEach(System.out::println);

}

nielspardon requested review from andrew-coleman, benbellick, bestbeforetoday and vbarua January 5, 2026 08:06

nielspardon reviewed Jan 8, 2026

View reviewed changes

isthmus/src/main/java/io/substrait/isthmus/OuterReferenceResolver.java Outdated Show resolved Hide resolved

nielspardon reviewed Jan 8, 2026

View reviewed changes

isthmus/src/main/java/io/substrait/isthmus/PreCalciteAggregateValidator.java Show resolved Hide resolved