solana: add instructionIndex to instruction #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgroul
force-pushed
the
instruction-index
branch
from
e83c294 to
0dd85c8
Compare
Contributor
Author
|
@eldargab should |
Collaborator
|
I think, it should be undefined. |
eldargab
requested changes
Nov 1, 2024
| } | ||
|
|
||
| let i: Instruction = { | ||
| innerInstructionIndex: this.innerPos, |
Collaborator
There was a problem hiding this comment.
I think, it is better to set it directly, rather than recalculating it here.
Contributor
Author
There was a problem hiding this comment.
do you mean outside of push method? it seems that inner instructions can be created in several methods so it's hard to track them 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.