Add first_name/last_name concat matching to org_vips body/subject rules#4515
Open
IndiaAce wants to merge 2 commits into
Open
Add first_name/last_name concat matching to org_vips body/subject rules#4515IndiaAce wants to merge 2 commits into
IndiaAce wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
…p relay with suspicious indicators
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
…ation with VIP impersonation
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
…th display name match, email mismatch
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
…subject (untrusted)
github-actions Bot
added a commit
to IndiaAce/sublime-rules
that referenced
this pull request
May 20, 2026
…suspicious indicators
github-actions Bot
added a commit
to IndiaAce/sublime-rules
that referenced
this pull request
May 20, 2026
… via Google Group relay with suspicious indicators
github-actions Bot
added a commit
to IndiaAce/sublime-rules
that referenced
this pull request
May 20, 2026
…ello board invitation with VIP impersonation
github-actions Bot
added a commit
to IndiaAce/sublime-rules
that referenced
this pull request
May 20, 2026
… with charitable donation fraud
github-actions Bot
added a commit
to IndiaAce/sublime-rules
that referenced
this pull request
May 20, 2026
…: Fake thread with display name match, email mismatch
github-actions Bot
added a commit
to IndiaAce/sublime-rules
that referenced
this pull request
May 20, 2026
…mpersonation in subject (untrusted)
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
…uspicious indicators
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
…via Google Group relay with suspicious indicators
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
…llo board invitation with VIP impersonation
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
…with charitable donation fraud
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
… Fake thread with display name match, email mismatch
github-actions Bot
added a commit
that referenced
this pull request
May 20, 2026
…personation in subject (untrusted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add alternative name matching logic to org_vips body/subject/HTML-based rules to handle cases where
display_name is stored as "Lastname, Firstname" instead of "Firstname Lastname".
Uses
strings.concat(.first_name, " ", .last_name)andstrings.concat(.last_name, ", ", .first_name)as additional
orconditions inside existingany($org_vips, ...)blocks.This is a test rule deployment to assess impact magnitude.
Affected rules
vip_impersonation_charity.ymlfake_thread_suspicious_indicators.ymlvip_impersonation_subject.ymlvip_impersonation_fake_thread.ymlimpersonation_google_groups_suspicious.ymlservice_abuse_trello_board_invite_vip.ymlAssociated samples
N/A - validation only (no TP canonical available)
Associated hunts
TBD - will be run after test rule deployment